Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49701
Change subject: (bug 39513) Check lqtnotifytalk property correctly
......................................................................
(bug 39513) Check lqtnotifytalk property correctly
Change-Id: I79e79c5df646081e7a96df82e5945b37ac663b0d
---
M classes/NewMessagesController.php
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads
refs/changes/01/49701/1
diff --git a/classes/NewMessagesController.php
b/classes/NewMessagesController.php
index 73f2ad0..3194e4f 100644
--- a/classes/NewMessagesController.php
+++ b/classes/NewMessagesController.php
@@ -204,11 +204,8 @@
NewMessages::recacheMessageCount( $row->wl_user
);
}
- $wantsTalkNotification = true;
-
- $wantsTalkNotification = $wantsTalkNotification &&
User::getDefaultOption( 'lqtnotifytalk' );
-
- if ( $wantsTalkNotification || $row->up_value ) {
+ $wantsTalkNotification = isset( $row->up_value ) ?
$row->up_value == '1' : User::getDefaultOption( 'lqtnotifytalk' );
+ if ( $wantsTalkNotification ) {
$notifyUsers[] = $row->wl_user;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/49701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79e79c5df646081e7a96df82e5945b37ac663b0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
