jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330999 )

Change subject: CanNotEditWidget: Hide properly when not active
......................................................................


CanNotEditWidget: Hide properly when not active

line-height: 0; doesn't work (any more?), and there's already a
display: block; rule when active, so we might as well apply
display: none; when not active.

Bug: T154762
Change-Id: I8d1ad6644e7110d0990f660b07dd47d7e2e1aa22
---
M modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git 
a/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less 
b/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
index 1f937e9..23d6b8b 100644
--- a/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
+++ b/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
@@ -1,8 +1,6 @@
 .flow-ui-canNotEditWidget {
-       // The line-height is defined for all of flow-board class. However,
-       // it has to be 0 in the case where the canNotEditWidget is empty
-       // otherwise it has a visible height.
-       line-height: 0;
+       // Hide when not active
+       display: none;
 
        &-active {
                /* @embed */

-- 
To view, visit https://gerrit.wikimedia.org/r/330999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d1ad6644e7110d0990f660b07dd47d7e2e1aa22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to