Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331336 )
Change subject: Hygiene: interactionToken -> token
......................................................................
Hygiene: interactionToken -> token
... for brevity.
Change-Id: I03626728fae36176cec0eb844efb92303377bfbf
---
M resources/ext.popups/actions.js
M resources/ext.popups/reducers/eventLogging.js
M tests/qunit/ext.popups/actions.test.js
M tests/qunit/ext.popups/reducers/eventLogging.test.js
4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/36/331336/1
diff --git a/resources/ext.popups/actions.js b/resources/ext.popups/actions.js
index b14a508..c575592 100644
--- a/resources/ext.popups/actions.js
+++ b/resources/ext.popups/actions.js
@@ -146,14 +146,14 @@
* @return {Redux.Thunk}
*/
actions.linkDwell = function ( el, event, gateway, generateToken ) {
- var interactionToken = generateToken();
+ var token = generateToken();
return function ( dispatch, getState ) {
dispatch( timedAction( {
type: types.LINK_DWELL,
el: el,
event: event,
- interactionToken: interactionToken
+ token: token
} ) );
mw.popups.wait( FETCH_START_DELAY )
diff --git a/resources/ext.popups/reducers/eventLogging.js
b/resources/ext.popups/reducers/eventLogging.js
index 360b48b..389640c 100644
--- a/resources/ext.popups/reducers/eventLogging.js
+++ b/resources/ext.popups/reducers/eventLogging.js
@@ -81,7 +81,7 @@
case popups.actionTypes.LINK_DWELL:
return nextState( state, {
interaction: {
- token: action.interactionToken,
+ token: action.token,
started: action.timestamp
}
} );
diff --git a/tests/qunit/ext.popups/actions.test.js
b/tests/qunit/ext.popups/actions.test.js
index 834bdc8..d1b5a1a 100644
--- a/tests/qunit/ext.popups/actions.test.js
+++ b/tests/qunit/ext.popups/actions.test.js
@@ -111,7 +111,7 @@
type: 'LINK_DWELL',
el: el,
event: event,
- interactionToken: '9876543210',
+ token: '9876543210',
timestamp: mw.now()
} );
diff --git a/tests/qunit/ext.popups/reducers/eventLogging.test.js
b/tests/qunit/ext.popups/reducers/eventLogging.test.js
index f8b726c..f74e6f5 100644
--- a/tests/qunit/ext.popups/reducers/eventLogging.test.js
+++ b/tests/qunit/ext.popups/reducers/eventLogging.test.js
@@ -136,7 +136,7 @@
action = {
type: 'LINK_DWELL',
- interactionToken: '0987654321',
+ token: '0987654321',
timestamp: mw.now()
};
@@ -144,7 +144,7 @@
mw.popups.reducers.eventLogging( state, action ),
{
interaction: {
- token: action.interactionToken,
+ token: action.token,
started: action.timestamp
}
}
@@ -161,7 +161,7 @@
state = mw.popups.reducers.eventLogging( state, {
type: 'LINK_DWELL',
- interactionToken: '0987654321',
+ token: '0987654321',
timestamp: now
} );
@@ -191,7 +191,7 @@
state = mw.popups.reducers.eventLogging( state, {
type: 'LINK_DWELL',
- interactionToken: '0987654321',
+ token: '0987654321',
timestamp: now
} );
--
To view, visit https://gerrit.wikimedia.org/r/331336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03626728fae36176cec0eb844efb92303377bfbf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: mpga
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
