Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/49798


Change subject: Removed escaping of apostrophes in template names (no longer 
necessary?)
......................................................................

Removed escaping of apostrophes in template names (no longer necessary?)

Change-Id: Id554d0da111db5b69e9fff119f5acffd1f96d9cc
---
M includes/SF_FormPrinter.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms 
refs/changes/98/49798/1

diff --git a/includes/SF_FormPrinter.php b/includes/SF_FormPrinter.php
index 3b4856d..376c235 100644
--- a/includes/SF_FormPrinter.php
+++ b/includes/SF_FormPrinter.php
@@ -522,7 +522,8 @@
                                        // POST does to strings anyway.
                                        $query_template_name = str_replace( 
'.', '_', $query_template_name );
                                        // ...and escape apostrophes.
-                                       $query_template_name = str_replace( 
"'", "\'", $query_template_name );
+                                       // (Or don't.)
+                                       //$query_template_name = str_replace( 
"'", "\'", $query_template_name );
                                        // Cycle through the other components.
                                        for ( $i = 2; $i < count( 
$tag_components ); $i++ ) {
                                                $component = 
$tag_components[$i];

-- 
To view, visit https://gerrit.wikimedia.org/r/49798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id554d0da111db5b69e9fff119f5acffd1f96d9cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to