Divadsn has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/331450 )
Change subject: Replace Linker::link() with LinkRenderer
......................................................................
Replace Linker::link() with LinkRenderer
Bug: T149346
Change-Id: Id76d2a26ded98db02a40d54b97f58e42e1efe3a0
---
M CleanChanges_body.php
1 file changed, 21 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CleanChanges
refs/changes/50/331450/1
diff --git a/CleanChanges_body.php b/CleanChanges_body.php
index 1cc51c0..52f26c2 100644
--- a/CleanChanges_body.php
+++ b/CleanChanges_body.php
@@ -1,5 +1,7 @@
<?php
+use MediaWiki\MediaWikiServices;
+
/**
* Generate a list of changes using an Enhanced system (use javascript).
*/
@@ -112,7 +114,8 @@
$logpage = new LogPage( $logtype );
$logname = $logpage->getName()->escaped();
$titleObj = SpecialPage::getTitleFor( 'Log', $logtype );
- $link = Linker::link( $titleObj, $logname );
+ $linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
+ $link = $linkRenderer->makeLink( $titleObj, $logname );
return $this->msg( 'parentheses' )->rawParams( $link
)->escaped();
}
@@ -138,19 +141,20 @@
# Should patrol-related stuff be shown?
$rc->unpatrolled = $this->showAsUnpatrolled( $rc );
+ $linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
$logEntry = $this->isLog( $rc );
if ( $logEntry ) {
$clink = $this->getLogTitle( $rc );
} elseif ( $rc->unpatrolled && $rc->getAttribute( 'rc_type' )
== RC_NEW ) {
# Unpatrolled new page, give rc_id in query
- $clink = linker::linkKnown(
+ $clink = $linkRenderer->makeKnownLink(
$titleObj,
null,
[],
[ 'rcid' => $rc_id ]
);
} else {
- $clink = Linker::linkKnown( $titleObj );
+ $clink = $linkRenderer->makeKnownLink( $titleObj );
}
$rc->watched = $watched;
@@ -230,21 +234,22 @@
'rcid' => $rc->unpatrolled ?
$rc->getAttribute( 'rc_id' ) : '',
] + $rc->_reqCurId;
- $rc->_curLink = Linker::linkKnown( $rc->getTitle(),
+ $linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
+ $rc->_curLink = $linkRenderer->makeKnownLink(
$rc->getTitle(),
$this->message['cur'], [], $querycur );
if ( $rc->getAttribute( 'rc_type' ) != RC_NEW ) {
- $rc->_diffLink = Linker::linkKnown(
$rc->getTitle(),
+ $rc->_diffLink = $linkRenderer->makeKnownLink(
$rc->getTitle(),
$this->message['diff'], [], $querydiff
);
}
if ( $rc->getAttribute( 'rc_last_oldid' ) != 0 ) {
// This is not the first revision
- $rc->_lastLink = Linker::linkKnown(
$rc->getTitle(),
+ $rc->_lastLink = $linkRenderer->makeKnownLink(
$rc->getTitle(),
$this->message['last'], [], $querydiff
);
}
- $rc->_histLink = Linker::link( $rc->getTitle(),
+ $rc->_histLink = $linkRenderer->makeLink(
$rc->getTitle(),
$this->message['hist'], [],
$rc->_reqCurId + [ 'action' => 'history' ]
);
@@ -304,6 +309,7 @@
# Article link
$items[] = $block[0]->link;
+ $linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
$log = $this->isLog( $block[0] );
if ( !$log ) {
# Changes
@@ -314,7 +320,7 @@
}
if ( !$isnew ) {
- $changes = Linker::linkKnown(
+ $changes = $linkRenderer->makeKnownLink(
$block[0]->getTitle(),
$nchanges[$n],
[],
@@ -405,6 +411,8 @@
* @return string
*/
protected function subEntries( array $block ) {
+ $linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
+
$lines = '';
foreach ( $block as $rcObj ) {
$items = [];
@@ -412,7 +420,7 @@
$time = $rcObj->timestamp;
if ( !$log ) {
- $time = Linker::linkKnown(
+ $time = $linkRenderer->makeKnownLink(
$rcObj->getTitle(),
$rcObj->timestamp,
[],
@@ -577,13 +585,15 @@
);
$tl .= Xml::element( 'span', [ 'id' => $rcl ], ' ' );
+ $linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
+
$items = [];
if ( $talkable ) {
$items[] = Linker::userTalkLink( $userId, $userText );
}
if ( $userId ) {
$targetPage = SpecialPage::getTitleFor(
'Contributions', $userText );
- $items[] = Linker::linkKnown( $targetPage,
+ $items[] = $linkRenderer->makeKnownLink( $targetPage,
$this->msg( 'contribslink' )->escaped() );
}
if ( $this->getUser()->isAllowed( 'block' ) ) {
@@ -593,7 +603,7 @@
$userrightsPage = new UserrightsPage();
if ( $userrightsPage->userCanChangeRights(
User::newFromId( $userId ) ) ) {
$targetPage = SpecialPage::getTitleFor(
'Userrights', $userText );
- $items[] = Linker::linkKnown( $targetPage,
+ $items[] = $linkRenderer->makeKnownLink(
$targetPage,
$this->msg(
'cleanchanges-changerightslink' )->escaped() );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/331450
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id76d2a26ded98db02a40d54b97f58e42e1efe3a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CleanChanges
Gerrit-Branch: master
Gerrit-Owner: Divadsn <divad.nnamtd...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
