Jack Phoenix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/331491 )

Change subject: Optimize calls to getLinkRenderer() by moving them out of 
foreach() loops
......................................................................

Optimize calls to getLinkRenderer() by moving them out of foreach() loops

Change-Id: I16ae5a411a276475ff1d70f80420bf8ce4493ce7
---
M BlogPageClass.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlogPage 
refs/changes/91/331491/1

diff --git a/BlogPageClass.php b/BlogPageClass.php
index 50b28aa..9cdde58 100644
--- a/BlogPageClass.php
+++ b/BlogPageClass.php
@@ -244,6 +244,7 @@
                $output = '<div class="blog-byline">' . wfMessage( 'blog-by' 
)->escaped() . ' ';
 
                $authors = '';
+               $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
                foreach ( $this->authors as $author ) {
                        $count++;
                        $userTitle = Title::makeTitle( NS_USER, 
$author['user_name'] );
@@ -255,7 +256,7 @@
                                        wfMessage( 'blog-and' )->escaped() .
                                        wfMessage( 'word-separator' 
)->escaped();
                        }
-                       $authors .= 
MediaWikiServices::getInstance()->getLinkRenderer()->makeLink(
+                       $authors .= $linkRenderer->makeLink(
                                $userTitle,
                                $author['user_name']
                        );
@@ -290,6 +291,7 @@
                $count = 0;
 
                $authors = '';
+               $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
                foreach ( $this->authors as $author ) {
                        $count++;
                        $userTitle = Title::makeTitle( NS_USER, 
$author['user_name'] );
@@ -301,7 +303,7 @@
                                        wfMessage( 'blog-and' )->escaped() .
                                        wfMessage( 'word-separator' 
)->escaped();
                        }
-                       $authors .= 
MediaWikiServices::getInstance()->getLinkRenderer()->makeLink(
+                       $authors .= $linkRenderer->makeLink(
                                $userTitle,
                                $author['user_name']
                        );

-- 
To view, visit https://gerrit.wikimedia.org/r/331491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16ae5a411a276475ff1d70f80420bf8ce4493ce7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlogPage
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to