jenkins-bot has submitted this change and it was merged.
Change subject: Drop unicode shenanigans from DevServer
......................................................................
Drop unicode shenanigans from DevServer
The 'weeee' factor of showing cute unicode isn't worth it if it means
we're more likely to break on systems where the default encoding for
stdout is not UTF-8.
Change-Id: Iaaa5c36f39140c6e6e15f16ab0518cc12076fa2d
---
M server/bin/eventlogging-devserver
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/server/bin/eventlogging-devserver
b/server/bin/eventlogging-devserver
index b406341..9743b20 100755
--- a/server/bin/eventlogging-devserver
+++ b/server/bin/eventlogging-devserver
@@ -116,32 +116,32 @@
}
for i, error in enumerate(errors):
- headers['Validation-Error-%d' % i] = str(error)
+ headers['Validation-Error-%d' % (i + 1)] = str(error)
status, headers = prepare_response('204 No Content', headers)
start_response(status, headers)
- print('── request ────────────')
+ print('-- request ------------')
print(log_line)
- print('── event ──────────────')
+ print('-- event --------------')
json = eventlogging.json.dumps(event, indent=2, sort_keys=True)
print(highlight(json, lexer, formatter), end='')
- print('── validation ──────────')
+ print('-- validation ----------')
for error in errors:
- print(ansiformat('red', '✘ Error:'), error)
+ print(ansiformat('_red_', 'Error:'), error)
if not errors:
- print(ansiformat('green', '✔ Valid.'))
+ print(ansiformat('_green_', 'Valid.'))
- print('────────────────────────')
+ print('------------------------')
return []
httpd = make_server(args.host, args.port, handle_event,
handler_class=EventLoggingHandler)
-print(ansiformat('*blue*', '⚒ EventLogging DevServer'))
+print(ansiformat('*blue*', '== EventLogging DevServer =='))
print('Receiving events at http://%s:%s/event.gif...' % (args.host, args.port))
try:
--
To view, visit https://gerrit.wikimedia.org/r/49626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaa5c36f39140c6e6e15f16ab0518cc12076fa2d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
