jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331102 )
Change subject: Simplified if-else
......................................................................
Simplified if-else
Change-Id: Ic20984d51392b35a96cbfb6fb53ef028cffc3472
---
M repo/includes/Hooks/InfoActionHookHandler.php
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/repo/includes/Hooks/InfoActionHookHandler.php
b/repo/includes/Hooks/InfoActionHookHandler.php
index f3e5cae..7305b20 100644
--- a/repo/includes/Hooks/InfoActionHookHandler.php
+++ b/repo/includes/Hooks/InfoActionHookHandler.php
@@ -82,11 +82,12 @@
private function getPageInfoRow( Title $title ) {
$entity = $this->entityIdLookup->getEntityIdForTitle( $title );
$subscriptions = $this->subscriptionLookup->getSubscribers(
$entity );
- if ( !$subscriptions ) {
- return $this->getNoSubscriptionText();
- } else {
+
+ if ( $subscriptions ) {
return $this->formatSubscriptions( $subscriptions,
$title );
}
+
+ return $this->getNoSubscriptionText();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/331102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic20984d51392b35a96cbfb6fb53ef028cffc3472
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
