Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49820
Change subject: (bug 45143) jQuery badge is always shown as important for
non-Latin numbers
......................................................................
(bug 45143) jQuery badge is always shown as important for non-Latin numbers
Change-Id: Ib8a36913df1ec4ae966551d1d5b8de712c34b96c
---
M resources/Resources.php
M resources/jquery/jquery.badge.js
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/20/49820/1
diff --git a/resources/Resources.php b/resources/Resources.php
index 51bf05f..31db997 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -134,6 +134,7 @@
'jquery.badge' => array(
'scripts' => 'resources/jquery/jquery.badge.js',
'styles' => 'resources/jquery/jquery.badge.css',
+ 'dependencies' => 'mediawiki.language',
),
'jquery.byteLength' => array(
'scripts' => 'resources/jquery/jquery.byteLength.js',
diff --git a/resources/jquery/jquery.badge.js b/resources/jquery/jquery.badge.js
index 16e7196..5593b72 100644
--- a/resources/jquery/jquery.badge.js
+++ b/resources/jquery/jquery.badge.js
@@ -41,9 +41,9 @@
isImportant = true;
// If we're displaying zero, ensure style to be non-important
- if ( text === 0 && displayZero ) {
+ if ( text == mw.language.convertNumber( 0 ) && displayZero ) {
isImportant = false;
- text = '0';
+ text = mw.language.convertNumber( 0 );
}
if ( text ) {
--
To view, visit https://gerrit.wikimedia.org/r/49820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8a36913df1ec4ae966551d1d5b8de712c34b96c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
