Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49835
Change subject: (bug 40595) AFTv5 controls not selectable with tab
......................................................................
(bug 40595) AFTv5 controls not selectable with tab
Because the link was missing a href-attribute, it was not being picked up as
link when tabbing through the page
Change-Id: Ibffda8664b40d9d3f2382ce3814d43db3c4a180c
---
M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5
refs/changes/35/49835/1
diff --git a/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
b/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
index 29c9d09..7de4254 100644
--- a/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
+++ b/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -232,7 +232,7 @@
</div>\
',
- helpToolTipTrigger: '<div
class="articleFeedbackv5-tooltip-trigger-wrap"><a
class="articleFeedbackv5-tooltip-trigger"><html:msg key="help-tooltip-title"
/></a></div>',
+ helpToolTipTrigger: '<div
class="articleFeedbackv5-tooltip-trigger-wrap"><a href="#"
class="articleFeedbackv5-tooltip-trigger"><html:msg key="help-tooltip-title"
/></a></div>',
ctaTitleConfirm: '\
<div class="articleFeedbackv5-confirmation-text">\
@@ -2456,7 +2456,8 @@
// Set up the tooltip trigger for the panel version
$wrapper.find( '.articleFeedbackv5-title-wrap' ).append(
$.articleFeedbackv5.templates.helpToolTipTrigger );
- $wrapper.find( '.articleFeedbackv5-tooltip-trigger' ).click(
function () {
+ $wrapper.find( '.articleFeedbackv5-tooltip-trigger' ).click(
function ( e ) {
+ e.preventDefault();
$.articleFeedbackv5.$holder.find(
'.articleFeedbackv5-tooltip' ).toggle();
} );
--
To view, visit https://gerrit.wikimedia.org/r/49835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibffda8664b40d9d3f2382ce3814d43db3c4a180c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
