jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331697 )
Change subject: mw.Api: Deprecate mw.Api.errors, mw.Api.warnings
......................................................................
mw.Api: Deprecate mw.Api.errors, mw.Api.warnings
Change-Id: I90f1ca1f26d647f34059fec342778568f7a5ff71
---
M RELEASE-NOTES-1.29
M resources/src/mediawiki/api.js
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Anomie: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index 4174876..905ea12 100644
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -175,6 +175,8 @@
* Linker::getInternalLinkAttributesObj() (deprecated since 1.25) was removed.
* Linker::getLinkAttributesInternal() (deprecated since 1.25) was removed.
* RedisConnectionPool::handleException (deprecated since 1.23) was removed.
+* The static properties mw.Api.errors and mw.Api.warnings, containing
incomplete
+ and outdated lists of errors/warnings returned by the API, are now
deprecated.
== Compatibility ==
diff --git a/resources/src/mediawiki/api.js b/resources/src/mediawiki/api.js
index a174f58..d5032da 100644
--- a/resources/src/mediawiki/api.js
+++ b/resources/src/mediawiki/api.js
@@ -427,9 +427,8 @@
/**
* @static
* @property {Array}
- * List of errors we might receive from the API.
- * For now, this just documents our expectation that there should be
similar messages
- * available.
+ * Very incomplete and outdated list of errors we might receive from
the API. Do not use.
+ * @deprecated since 1.29
*/
mw.Api.errors = [
// occurs when POST aborted
@@ -487,17 +486,18 @@
'stashwrongowner',
'stashnosuchfilekey'
];
+ mw.log.deprecate( mw.Api, 'errors', mw.Api.errors );
/**
* @static
* @property {Array}
- * List of warnings we might receive from the API.
- * For now, this just documents our expectation that there should be
similar messages
- * available.
+ * Very incomplete and outdated list of warnings we might receive from
the API. Do not use.
+ * @deprecated since 1.29
*/
mw.Api.warnings = [
'duplicate',
'exists'
];
+ mw.log.deprecate( mw.Api, 'warnings', mw.Api.warnings );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/331697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90f1ca1f26d647f34059fec342778568f7a5ff71
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
