GWicke has submitted this change and it was merged.
Change subject: Use Node.childNodes instead of Element.children.
......................................................................
Use Node.childNodes instead of Element.children.
jsdom defines 'children' on Node, but that's not in the DOM; the DOM
(and domino) specifies that only Element nodes have the 'children'
property. Use 'childNodes' instead, which really is defined on Node.
Change-Id: Ie3dc5b5f6c9c8b695ab78c04a9db632bd1133947
---
M js/lib/mediawiki.DOMUtils.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
GWicke: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/js/lib/mediawiki.DOMUtils.js b/js/lib/mediawiki.DOMUtils.js
index a3e280c..17dff72 100644
--- a/js/lib/mediawiki.DOMUtils.js
+++ b/js/lib/mediawiki.DOMUtils.js
@@ -240,7 +240,7 @@
},
hasElementChild: function(node) {
- var children = node.children;
+ var children = node.childNodes;
for (var i = 0, n = children.length; i < n; i++) {
if (this.isElt(children[i])) {
return true;
@@ -266,7 +266,7 @@
}
// Descend into children -- walk backward
- var children = node.children;
+ var children = node.childNodes;
for (var n = children.length, i = n-1; i >= 0; i--) {
var c = children[i];
if (this.isElt(c)) {
--
To view, visit https://gerrit.wikimedia.org/r/49495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3dc5b5f6c9c8b695ab78c04a9db632bd1133947
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
