MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/331814 )

Change subject: Remove b/c stuff
......................................................................

Remove b/c stuff

Change-Id: I7e878442569e58e34c577d2d52e3a617e3858f04
---
M includes/JCDataApi.php
1 file changed, 4 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/JsonConfig 
refs/changes/14/331814/1

diff --git a/includes/JCDataApi.php b/includes/JCDataApi.php
index 4697abb..4ac7848 100644
--- a/includes/JCDataApi.php
+++ b/includes/JCDataApi.php
@@ -14,22 +14,14 @@
                $params = $this->extractRequestParams();
                $jct = JCSingleton::parseTitle( $params['title'], NS_DATA );
                if ( !$jct ) {
-                       if ( is_callable( [ $this, 'dieWithError' ] ) ) {
-                               $this->dieWithError( [ 'apierror-invalidtitle', 
wfEscapeWikiText( $params['title'] ) ] );
-                       } else {
-                               $this->dieUsageMsg( [ 'invalidtitle', 
$params['title'] ] );
-                       }
+                       $this->dieWithError( [ 'apierror-invalidtitle', 
wfEscapeWikiText( $params['title'] ) ] );
                }
 
                $data = JCSingleton::getContent( $jct );
                if ( !$data ) {
-                       if ( is_callable( [ $this, 'dieWithError' ] ) ) {
-                               $this->dieWithError(
-                                       [ 'apierror-invalidtitle', 
wfEscapeWikiText( $jct->getPrefixedText() ) ]
-                               );
-                       } else {
-                               $this->dieUsageMsg( [ 'invalidtitle', $jct ] );
-                       }
+                       $this->dieWithError(
+                               [ 'apierror-invalidtitle', wfEscapeWikiText( 
$jct->getPrefixedText() ) ]
+                       );
                } elseif ( !method_exists( $data, 'getLocalizedData' ) ) {
                        $data = $data->getData();
                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/331814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e878442569e58e34c577d2d52e3a617e3858f04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to