jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331816 )
Change subject: ui.CommandHelpRegistry: fix extending of existing command
......................................................................
ui.CommandHelpRegistry: fix extending of existing command
We were accidentally discarding the existing command details, since 16fa88e9.
Change-Id: Ie749f7532036b7285d868c640ddbf42e2159e09d
---
M src/ui/ve.ui.CommandHelpRegistry.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ui/ve.ui.CommandHelpRegistry.js
b/src/ui/ve.ui.CommandHelpRegistry.js
index 84bbf8f..e05944f 100644
--- a/src/ui/ve.ui.CommandHelpRegistry.js
+++ b/src/ui/ve.ui.CommandHelpRegistry.js
@@ -43,7 +43,7 @@
details = ve.copy( details );
details.sequences = ( existingCommand.sequences || []
).concat( details.sequences );
}
- ve.extendObject( existingCommand, details );
+ details = ve.extendObject( existingCommand, details );
}
details.group = groupName;
--
To view, visit https://gerrit.wikimedia.org/r/331816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie749f7532036b7285d868c640ddbf42e2159e09d
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
