jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331468 )
Change subject: Arrange Special:Version/credits into columns and remove space
at top
......................................................................
Arrange Special:Version/credits into columns and remove space at top
Make the long list of names more manageable and readable.
Change-Id: I3bb5da73ecf0c46b77a675324dcd62c9c4ea60da
---
M CREDITS
M includes/specials/SpecialVersion.php
M resources/src/mediawiki.special/mediawiki.special.version.css
3 files changed, 16 insertions(+), 4 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CREDITS b/CREDITS
index d9ff970..b37edf2 100644
--- a/CREDITS
+++ b/CREDITS
@@ -1,10 +1,9 @@
-{{int:version-credits-summary}}
-<!--
+{{int:version-credits-summary}} <!--
MediaWiki 1.28 is a collaborative project released under the
GNU General Public License v2. We would like to recognize the
following names for their contribution to the product.
--->
-<!-- Please notice that the following can be found parsed under
Special:Version/Credits -->
+
+The following list can be found parsed under Special:Version/Credits -->
== Contributors ==
<!-- Updates to this list made with maintenance/updateCredits.php -->
diff --git a/includes/specials/SpecialVersion.php
b/includes/specials/SpecialVersion.php
index 272f074..708eced 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -78,9 +78,16 @@
// Now figure out what to do
switch ( strtolower( $parts[0] ) ) {
case 'credits':
+ $out->addModuleStyles(
'mediawiki.special.version' );
+
$wikiText = '{{int:version-credits-not-found}}';
if ( $extName === 'MediaWiki' ) {
$wikiText = file_get_contents( $IP .
'/CREDITS' );
+ // Put the contributor list into columns
+ $wikiText = str_replace(
+ [ '<!-- BEGIN CONTRIBUTOR LIST
-->', '<!-- END CONTRIBUTOR LIST -->' ],
+ [ '<div
class="mw-version-credits">', '</div>' ],
+ $wikiText );
} elseif ( ( $extNode !== null ) && isset(
$extNode['path'] ) ) {
$file = $this->getExtAuthorsFileName(
dirname( $extNode['path'] ) );
if ( $file ) {
diff --git a/resources/src/mediawiki.special/mediawiki.special.version.css
b/resources/src/mediawiki.special/mediawiki.special.version.css
index 5b259e7..ebb6b48 100644
--- a/resources/src/mediawiki.special/mediawiki.special.version.css
+++ b/resources/src/mediawiki.special/mediawiki.special.version.css
@@ -18,3 +18,9 @@
.mw-version-ext-vcs-version {
unicode-bidi: embed;
}
+
+.mw-version-credits {
+ column-width: 18em;
+ -moz-column-width: 18em;
+ -webkit-column-width: 18em;
+}
--
To view, visit https://gerrit.wikimedia.org/r/331468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bb5da73ecf0c46b77a675324dcd62c9c4ea60da
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TTO <at.li...@live.com.au>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: TTO <at.li...@live.com.au>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
