Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49838
Change subject: Use .item() accessor for DOM attributes.
......................................................................
Use .item() accessor for DOM attributes.
Avoid using array-access notation for DOM attribute lists.
Change-Id: Idb38d07b6e56901860faa9a2c0f8ceadea09654f
---
M js/lib/mediawiki.DOMUtils.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/38/49838/1
diff --git a/js/lib/mediawiki.DOMUtils.js b/js/lib/mediawiki.DOMUtils.js
index 17dff72..3129485 100644
--- a/js/lib/mediawiki.DOMUtils.js
+++ b/js/lib/mediawiki.DOMUtils.js
@@ -128,7 +128,7 @@
var attribs = node.attributes,
kvs = [];
for(var i = 0, l = attribs.length; i < l; i++) {
- var attrib = attribs[i];
+ var attrib = attribs.item(i);
kvs.push(new KV(attrib.name, attrib.value));
}
return kvs;
--
To view, visit https://gerrit.wikimedia.org/r/49838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb38d07b6e56901860faa9a2c0f8ceadea09654f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
