[MediaWiki-commits] [Gerrit] (Bug 45141) Move the timestamp in the enhanced-rc lists into... - change (mediawiki/core)

[Isarra (Code Review)]

Isarra has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/49841


Change subject: (Bug 45141) Move the timestamp in the enhanced-rc lists into 
the toggle object for collapsible items
......................................................................

(Bug 45141) Move the timestamp in the enhanced-rc lists into the toggle object 
for collapsible items

In retrospect this was an absolutely horrible idea, but for some reason I 
cannot seem to bring myself to just chuck it.

Change-Id: Ica3b076175c264091b5e0804c67c52389bcb4eba
---
M includes/ChangesList.php
M resources/mediawiki.special/mediawiki.special.changeslist.css
2 files changed, 22 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/41/49841/1

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index a9b9c31..32f4c66 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -952,19 +952,19 @@
                                implode( $this->message['semicolon-separator'], 
$users )
                        )->escaped() . '</span>';
 
-               $tl = '<span class="mw-collapsible-toggle 
mw-enhancedchanges-arrow mw-enhancedchanges-arrow-space"></span>';
-               $r .= "<td>$tl</td>";
+               # Timestamp and toggle
+               $tl = '"mw-collapsible-toggle mw-enhancedchanges-arrow 
mw-enhancedchanges-toggle"';
+               $r .= "<td><span class=$tl>{$block[0]->timestamp}</span></td>";
 
                # Main line
-               $r .= '<td class="mw-enhanced-rc">' . 
$this->recentChangesFlags( array(
+               $r .= '<td class="mw-enhanced-rc mw-enhanced-rc-flags">' . 
$this->recentChangesFlags( array(
                        'newpage' => $isnew, # show, when one have this flag
                        'minor' => $allMinors, # show only, when all have this 
flag
                        'unpatrolled' => $unpatrolled, # show, when one have 
this flag
                        'bot' => $allBots, # show only, when all have this flag
                ) );
 
-               # Timestamp
-               $r .= '&#160;' . $block[0]->timestamp . '&#160;</td><td>';
+               $r .= '</td><td>';
 
                # Article link
                if( $namehidden ) {
@@ -1061,14 +1061,14 @@
                        $classes = array();
                        $type = $rcObj->mAttribs['rc_type'];
 
-                       $r .= '<tr><td></td><td class="mw-enhanced-rc">';
+                       $r .= '<tr><td></td><td class="mw-enhanced-rc 
mw-enhanced-rc-flags">';
                        $r .= $this->recentChangesFlags( array(
                                'newpage' => $type == RC_NEW,
                                'minor' => $rcObj->mAttribs['rc_minor'],
                                'unpatrolled' => $rcObj->unpatrolled,
                                'bot' => $rcObj->mAttribs['rc_bot'],
                        ) );
-                       $r .= '&#160;</td><td 
class="mw-enhanced-rc-nested"><span class="mw-enhanced-rc-time">';
+                       $r .= '</td><td class="mw-enhanced-rc-nested"><span 
class="mw-enhanced-rc-time">';
 
                        $params = $queryParams;
 
@@ -1206,7 +1206,7 @@
                $r = Html::openElement( 'table', array( 'class' => $classes ) ) 
.
                        Html::openElement( 'tr' );
 
-               $r .= '<td class="mw-enhanced-rc"><span 
class="mw-enhancedchanges-arrow-space"></span>';
+               $r .= '<td class="mw-enhanced-rc"><span 
class="mw-enhancedchanges-toggle">' . $rcObj->timestamp .'</span></td><td 
class="mw-enhanced-rc mw-enhanced-rc-flags">';
                # Flag and Timestamp
                if( $type == RC_MOVE || $type == RC_MOVE_OVER_REDIRECT ) {
                        $r .= '&#160;&#160;&#160;&#160;'; // 4 flags -> 4 spaces
@@ -1218,7 +1218,7 @@
                                'bot' => $rcObj->mAttribs['rc_bot'],
                        ) );
                }
-               $r .= '&#160;' . $rcObj->timestamp . '&#160;</td><td>';
+               $r .= '</td><td>';
                # Article or log link
                if( $logType ) {
                        $logPage = new LogPage( $logType );
diff --git a/resources/mediawiki.special/mediawiki.special.changeslist.css 
b/resources/mediawiki.special/mediawiki.special.changeslist.css
index fcdeba1..abbee1a 100644
--- a/resources/mediawiki.special/mediawiki.special.changeslist.css
+++ b/resources/mediawiki.special/mediawiki.special.changeslist.css
@@ -18,8 +18,14 @@
        font-family: monospace;
 }
 
+.mw-enhancedchanges-toggle,
 .mw-enhanced-rc-time {
        font-family: monospace;
+}
+
+table.mw-enhanced-rc td.mw-enhanced-rc-flags {
+       padding-left: .5em;
+       padding-right: .5em;
 }
 
 table.mw-enhanced-rc td.mw-enhanced-rc-nested {
@@ -36,18 +42,19 @@
        display: none;
 }
 
-.mw-enhancedchanges-arrow-space {
-       display: inline-block;
-       *display: inline; /* IE7 and below */
-       zoom: 1;
-       width: 15px;
-       height: 15px;
+.mw-enhancedchanges-toggle {
+       padding-left: 17px;
 }
+
+
 
 /* let it look like it is clickable */
 .mw-enhancedchanges-arrow.mw-collapsible-toggle {
        cursor: pointer;
 }
+.mw-enhancedchanges-arrow.mw-collapsible-toggle:hover {
+       text-decoration: underline;
+}
 
 .mw-enhancedchanges-arrow.mw-collapsible-toggle-collapsed {
        /* @embed */

-- 
To view, visit https://gerrit.wikimedia.org/r/49841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica3b076175c264091b5e0804c67c52389bcb4eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Isarra <zhoris...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits