[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] Fix for positional_arg behavior of GeneratorFactory

[Xqt (Code Review)]

Xqt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/331965 )

Change subject: [bugfix] Fix for positional_arg behavior of GeneratorFactory
......................................................................

[bugfix] Fix for positional_arg behavior of GeneratorFactory

When a positional arg is used by GeneratorFactory the argument may contain
a colon. The colon splits the option arg from the option value. This patch
enables positional arguments with colon inside.

Bug: T155227
Change-Id: Id61dfd57e514a845d952b1d710b0bf7295fc0a1c
---
M pywikibot/pagegenerators.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/65/331965/1

diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index 61dacdb..691c184 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -14,7 +14,7 @@
 &params;
 """
 #
-# (C) Pywikibot team, 2008-2016
+# (C) Pywikibot team, 2008-2017
 #
 # Distributed under the terms of the MIT license.
 #
@@ -633,14 +633,15 @@
             return v if (v is None or v is '') else int(v)
 
         arg, sep, value = arg.partition(':')
-        if value == '':
-            value = None
 
         gen = None
         if not arg.startswith('-') and self._positional_arg_name:
-            value = arg
+            value = '{0}:{1}'.format(arg, value)
             arg = '-' + self._positional_arg_name
 
+        if value == '':
+            value = None
+
         if arg == '-filelinks':
             if not value:
                 value = i18n.input(

-- 
To view, visit https://gerrit.wikimedia.org/r/331965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id61dfd57e514a845d952b1d710b0bf7295fc0a1c
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits