DatGuy has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332036 )
Change subject: Fix extension UIFeedback failing tests ...................................................................... Fix extension UIFeedback failing tests Extension UIFeedback failing tests due to missing apihelp messages Bug: T155048 Change-Id: I075200d35e5c2eb9eae85636a70d30b3818fcfd9 --- M ApiUiFeedback.php M i18n/en.json M i18n/qqq.json 3 files changed, 54 insertions(+), 36 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UIFeedback refs/changes/36/332036/1 diff --git a/ApiUiFeedback.php b/ApiUiFeedback.php index 2c9b06d..0111178 100644 --- a/ApiUiFeedback.php +++ b/ApiUiFeedback.php @@ -151,11 +151,7 @@ } - // Description - public function getDescription() { - return 'This Api handles requests from the UIFeedback Extension'; - } - + // apihelp-related stuff // parameter. public function getAllowedParams() { return array( @@ -206,38 +202,14 @@ ); } - // Describe the parameter - public function getParamDescription() { - return array_merge( parent::getParamDescription(), array( - 'mode' => 'method to use in the api (feedback, review, count)', - 'ui-feedback-anonymous' => 'true, if the user want to post the feedback privately', - 'ui-feedback-username' => 'the username of the user ', - 'ui-feedback-notify' => '1, if the user wants be be notified about updated on this issue', - 'ui-feedback-task' => 'the task (position in the list of tasks)', - 'ui-feedback-task-other' => 'free text, if other is selected in task', - 'ui-feedback-done' => '0: no, 1: yes, undefined', - 'ui-feedback-type' => '0: Screenshot, 1: Questionnaire', - 'ui-feedback-url' => 'the url from where the feedback came', - 'ui-feedback-importance' => 'an integer for the importance, 0-5', - 'ui-feedback-happened' => '0 unknown, 1 not expected, 2 confused, 3 missing feature, 4 other', - 'ui-feedback-text1' => 'the comment (free text)', - 'ui-feedback-useragent' => 'the useragent', - 'file' => 'binary data (the rendered png)', - 'id' => 'for review-mode: feedback-id', - 'status' => 'for review-mode: review-status', - 'comment' => 'for review-mode: review-comment', - 'type' => 'type of stat-request', - 'click' => '', - 'show' => '', - 'sent' => '', - ) ); - } - - // Get examples // TODO - public function getExamples() { + /** + * @see ApiBase::getExamplesMessages() + */ + protected function getExamplesMessages() { return array( - 'api.php?action=apisampleoutput&face=O_o&format=xml' => 'Get a sideways look (and the usual predictions)' + 'api.php?action=apisampleoutput&face=O_o&format=xml' + => 'apihelp-uifeedback-example' ); } } diff --git a/i18n/en.json b/i18n/en.json index fc8de1a..0cd700f 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -104,5 +104,28 @@ "ui-feedback-special-screenshot-error": "something went wrong finding the screenshot", "ui-feedback-special-review": "Review", "ui-feedback-special-previous-notes": "Previous Notes", - "ui-feedback-special-info": "Info" + "ui-feedback-special-info": "Info", + "apihelp-uifeedback-description": "This Api handles requests from the UIFeedback Extension", + "apihelp-uifeedback-example": "Get a sideways look (and the usual predictions)", + "apihelp-uifeedback-param-mode": "method to use in the api (feedback, review, count)", + "apihelp-uifeedback-param-ui-feedback-anonymous": "true, if the user want to post the feedback privately", + "apihelp-uifeedback-param-ui-feedback-username": "the username of the user ", + "apihelp-uifeedback-param-ui-feedback-notify": "1, if the user wants be be notified about updated on this issue", + "apihelp-uifeedback-param-ui-feedback-task": "the task (position in the list of tasks)", + "apihelp-uifeedback-param-ui-feedback-task-other": "free text, if other is selected in task", + "apihelp-uifeedback-param-ui-feedback-done": "0: no, 1: yes, undefined", + "apihelp-uifeedback-param-ui-feedback-type": "0: Screenshot, 1: Questionnaire", + "apihelp-uifeedback-param-ui-feedback-url": "the url from where the feedback came", + "apihelp-uifeedback-param-ui-feedback-importance": "an integer for the importance, 0-5", + "apihelp-uifeedback-param-ui-feedback-happened": "0 unknown, 1 not expected, 2 confused, 3 missing feature, 4 other", + "apihelp-uifeedback-param-ui-feedback-text1": "the comment (free text)", + "apihelp-uifeedback-param-ui-feedback-useragent": "the useragent", + "apihelp-uifeedback-param-file": "binary data (the rendered png)", + "apihelp-uifeedback-param-id": "for review-mode: feedback-id", + "apihelp-uifeedback-param-status": "for review-mode: review-status", + "apihelp-uifeedback-param-comment": "for review-mode: review-comment", + "apihelp-uifeedback-param-type": "type of stat-request", + "apihelp-uifeedback-param-click": "", + "apihelp-uifeedback-param-show": "", + "apihelp-uifeedback-param-sent": "" } diff --git a/i18n/qqq.json b/i18n/qqq.json index e2ada76..a331b79 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -97,4 +97,27 @@ "ui-feedback-special-review": "headline for the review section", "ui-feedback-special-previous-notes": "headline for previous reviews", "ui-feedback-special-info": "label for the freetext of the review" + "apihelp-uifeedback-description": "{{doc-apihelp-description|uifeedback}}", + "apihelp-uifeedback-example": "{{doc-apihelp-example|uifeedback}}", + "apihelp-uifeedback-param-mode": "{{doc-apihelp-param|uifeedback|mode}}", + "apihelp-uifeedback-param-ui-feedback-anonymous": "{{doc-apihelp-param|uifeedback|ui-feedback-anonymous}}", + "apihelp-uifeedback-param-ui-feedback-username": "{{doc-apihelp-param|uifeedback|ui-feedback-username}}", + "apihelp-uifeedback-param-ui-feedback-notify": "{{doc-apihelp-param|uifeedback|ui-feedback-notify}}", + "apihelp-uifeedback-param-ui-feedback-task": "{{doc-apihelp-param|uifeedback|ui-feedback-task}}", + "apihelp-uifeedback-param-ui-feedback-task-other": "{{doc-apihelp-param|uifeedback|ui-feedback-task-other}}", + "apihelp-uifeedback-param-ui-feedback-done": "{{doc-apihelp-param|uifeedback|ui-feedback-done}}", + "apihelp-uifeedback-param-ui-feedback-type": "{{doc-apihelp-param|uifeedback|ui-feedback-type}}", + "apihelp-uifeedback-param-ui-feedback-url": "{{doc-apihelp-param|uifeedback|ui-feedback-url}}", + "apihelp-uifeedback-param-ui-feedback-importance": "{{doc-apihelp-param|uifeedback|ui-feedback-importance}}", + "apihelp-uifeedback-param-ui-feedback-happened": "{{doc-apihelp-param|uifeedback|ui-feedback-happened}}", + "apihelp-uifeedback-param-ui-feedback-text1": "{{doc-apihelp-param|uifeedback|ui-feedback-text1}}", + "apihelp-uifeedback-param-ui-feedback-useragent": "{{doc-apihelp-param|uifeedback|ui-feedback-useragent}}", + "apihelp-uifeedback-param-file": "{{doc-apihelp-param|uifeedback|file}}", + "apihelp-uifeedback-param-id": "{{doc-apihelp-param|uifeedback|id}}", + "apihelp-uifeedback-param-status": "{{doc-apihelp-param|uifeedback|status}}", + "apihelp-uifeedback-param-comment": "{{doc-apihelp-param|uifeedback|comment}}", + "apihelp-uifeedback-param-type": "{{doc-apihelp-param|uifeedback|type}}", + "apihelp-uifeedback-param-click": "{{doc-apihelp-param|uifeedback|click}}", + "apihelp-uifeedback-param-show": "{{doc-apihelp-param|uifeedback|show}}", + "apihelp-uifeedback-param-sent": "{{doc-apihelp-param|uifeedback|sent}}" } -- To view, visit https://gerrit.wikimedia.org/r/332036 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I075200d35e5c2eb9eae85636a70d30b3818fcfd9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UIFeedback Gerrit-Branch: master Gerrit-Owner: DatGuy <datguyst...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits