Aude has submitted this change and it was merged.
Change subject: (bug 45167) Don't use a closure for wgExtensionFunctions
......................................................................
(bug 45167) Don't use a closure for wgExtensionFunctions
Change-Id: I28bb0cbb7ec10037acce489fdb8782372bf55187
---
M lib/WikibaseLib.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Aude: Verified; Looks good to me, approved
diff --git a/lib/WikibaseLib.php b/lib/WikibaseLib.php
index abe0c98..6502323 100644
--- a/lib/WikibaseLib.php
+++ b/lib/WikibaseLib.php
@@ -221,7 +221,9 @@
$wgAutoloadClasses['Wikibase\Lib\Test\Serializers\UnserializerBaseTest'] =
$dir . 'tests/phpunit/serializers/UnserializerBaseTest.php';
// TODO: this is not nice, figure out a better design
-$wgExtensionFunctions[] = function() {
+$wgExtensionFunctions[] = 'efWikibaseLib';
+
+function efWikibaseLib() {
global $wgDataTypes;
$libRegistry = new \Wikibase\LibRegistry(
\Wikibase\Settings::singleton() );
@@ -234,7 +236,7 @@
\Wikibase\TemplateRegistry::singleton()->addTemplates( include( __DIR__
. "/resources/templates.php" ) );
return true;
-};
+}
$wgValueParsers['wikibase-entityid'] = 'Wikibase\Lib\EntityIdParser';
$wgDataValues['wikibase-entityid'] = 'Wikibase\EntityId';
--
To view, visit https://gerrit.wikimedia.org/r/49854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28bb0cbb7ec10037acce489fdb8782372bf55187
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
