Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49939
Change subject: Refactoring: rename lightbox and popup to guider
......................................................................
Refactoring: rename lightbox and popup to guider
Change-Id: I5b67713e3042d36a1d7c5c9afc4b1ba310c2e96f
---
M features/guided_tour.feature
M features/step_definitions/guided_tour_steps.rb
2 files changed, 21 insertions(+), 28 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests
refs/changes/39/49939/1
diff --git a/features/guided_tour.feature b/features/guided_tour.feature
index 7e09db3..6f8928a 100644
--- a/features/guided_tour.feature
+++ b/features/guided_tour.feature
@@ -1,28 +1,21 @@
Feature: Guided Tour
- Scenario: Check for Ready to Help lightbox
+ Scenario: Check for Ready to Help guider
Given I am at random page
- When I append ?tour=gettingstarted to the page URL
- Then I should see the guider lightbox
+ When I append ?tour=gettingstarted to the page URL
+ Then I should see the Ready to help guider
- Scenario: Check for Click Edit popup
- Given I am on a page with Ready to Help lightbox
+ Scenario: Check for Click Edit guider
+ Given I am on a page with Ready to Help guider
When I click Okay
- Then I should see a Click Edit popup
+ Then I should see a Click Edit guider
- Scenario: Check for Preview popup
- Given I am on a page with Click Edit popup
+ Scenario: Check for Preview guider
+ Given I am on a page with Click Edit guider
When I click the Edit link on the wiki page
- Then I should see a Preview popup
+ Then I should see a Preview guider
- Scenario: Check for You're almost finished popup
- Given I am on a page with Preview popup
+ Scenario: Check for You're almost finished guider
+ Given I am on a page with Preview guider
When I click Show Preview on the wiki page
- Then I should see a You're almost finished popup
-
-
-
-
-
-
-
+ Then I should see a You're almost finished guider
diff --git a/features/step_definitions/guided_tour_steps.rb
b/features/step_definitions/guided_tour_steps.rb
index 6b39fe9..1d5d298 100644
--- a/features/step_definitions/guided_tour_steps.rb
+++ b/features/step_definitions/guided_tour_steps.rb
@@ -4,11 +4,11 @@
@browser.goto(@browser.url + '?tour=gettingstarted')
end
-Then /^I should see the guider lightbox$/ do
+Then /^I should see the Ready to help guider$/ do
on(TourPage).guider1_element.should exist
end
-Given /^I am on a page with Ready to Help lightbox$/ do
+Given /^I am on a page with Ready to Help guider$/ do
step 'I am at random page'
step 'I append ?tour=gettingstarted to the page URL'
end
@@ -17,12 +17,12 @@
on(TourPage).okay_element.when_present.click
end
-Then /^I should see a Click Edit popup$/ do
+Then /^I should see a Click Edit guider$/ do
on(TourPage).guider2_element.should exist
end
-Given /^I am on a page with Click Edit popup$/ do
- step 'I am on a page with Ready to Help lightbox'
+Given /^I am on a page with Click Edit guider$/ do
+ step 'I am on a page with Ready to Help guider'
step 'I click Okay'
end
@@ -30,12 +30,12 @@
on(TourPage).edit
end
-Then /^I should see a Preview popup$/ do
+Then /^I should see a Preview guider$/ do
on(TourPage).guider3_element.should exist
end
-Given /^I am on a page with Preview popup$/ do
- step 'I am on a page with Click Edit popup'
+Given /^I am on a page with Preview guider$/ do
+ step 'I am on a page with Click Edit guider'
step 'I click the Edit link on the wiki page'
end
@@ -43,7 +43,7 @@
on(TourPage).preview
end
-Then /^I should see a You're almost finished popup$/ do
+Then /^I should see a You're almost finished guider$/ do
on(TourPage).guider4_element.should exist
end
--
To view, visit https://gerrit.wikimedia.org/r/49939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b67713e3042d36a1d7c5c9afc4b1ba310c2e96f
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
