Harej has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332433 )

Change subject: Making it so that the browse images button only shows up once.
......................................................................

Making it so that the browse images button only shows up once.

Bug: T155454
Change-Id: I0dbeb6da58423234aa3939c597816bf59d6887d9
---
M modules/ext.CollaborationKit.hubimage.js
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/33/332433/1

diff --git a/modules/ext.CollaborationKit.hubimage.js 
b/modules/ext.CollaborationKit.hubimage.js
index 76d1b4f..a5264fa 100644
--- a/modules/ext.CollaborationKit.hubimage.js
+++ b/modules/ext.CollaborationKit.hubimage.js
@@ -44,7 +44,7 @@
                                                        .css( 'margin-bottom', 
'10px' );
 
                                                // Set form value
-                                               $( '.mw-ck-hubimageinput input, 
div#wpCollabHubImage input' ).val( fileTitle );
+                                               $( '.mw-ck-hubimageinput input' 
).val( fileTitle );
 
                                                dialog.close( { action: action 
} );
                                        } );
@@ -79,12 +79,12 @@
        hubimageBrowserButton.setLabel( mw.msg( 
'collaborationkit-hubimage-launchbutton' ) );
        hubimageBrowserButton.on( 'click', openItUp );
 
-       $( 'div.mw-ck-hubimageinput, div#wpCollabHubImage' ).addClass( 
'hubimage-browser-field' );
-       $( 'div.mw-ck-hubimageinput label, div#wpCollabHubImage' )
+       $( 'div.mw-ck-hubimageinput' ).addClass( 'hubimage-browser-field' );
+       $( 'div.mw-ck-hubimageinput label' )
                .append( '<img class="hubimagePreview" /><div 
class="hubimageBrowserButton">' )
                .append( hubimageBrowserButton.$element )
                .append( '</div>' );
-       $( 'div.mw-ck-hubimageinput input, div#wpCollabHubImage input' ).css( 
'display', 'none' );
+       $( 'div.mw-ck-hubimageinput input' ).css( 'display', 'none' );
 
        // Load current hub image
        if ( $( 'input#wpCollabHubImage' ).val() !== undefined ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/332433
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dbeb6da58423234aa3939c597816bf59d6887d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to