Filippo Giunchedi has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/332756 )

Change subject: graphite: fix upload vs uploads alert for reqstats
......................................................................


graphite: fix upload vs uploads alert for reqstats

Cache name for upload is singular, broken since Ia5026cb25d

Change-Id: I7eeb3b3135286a2bfc62b931e35d1ba58e14eab1
---
M modules/role/manifests/graphite/alerts/reqstats.pp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Filippo Giunchedi: Verified; Looks good to me, approved



diff --git a/modules/role/manifests/graphite/alerts/reqstats.pp 
b/modules/role/manifests/graphite/alerts/reqstats.pp
index 4e8970d..c9e8e3f 100644
--- a/modules/role/manifests/graphite/alerts/reqstats.pp
+++ b/modules/role/manifests/graphite/alerts/reqstats.pp
@@ -51,9 +51,9 @@
         nagios_critical => false,
     }
 
-    monitoring::graphite_threshold { 'reqstats-5xx-uploads':
-        description     => 'Uploads HTTP 5xx reqs/min',
-        metric          => 
'sumSeries(varnish.*.uploads.frontend.request.client.status.5xx.sum)',
+    monitoring::graphite_threshold { 'reqstats-5xx-upload':
+        description     => 'Upload HTTP 5xx reqs/min',
+        metric          => 
'sumSeries(varnish.*.upload.frontend.request.client.status.5xx.sum)',
         warning         => $settings['warning'],
         critical        => $settings['critical'],
         from            => $settings['cron'],

-- 
To view, visit https://gerrit.wikimedia.org/r/332756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7eeb3b3135286a2bfc62b931e35d1ba58e14eab1
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to