Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332758 )
Change subject: FloatableElement: More correctly decide if we need custom
position
......................................................................
FloatableElement: More correctly decide if we need custom position
Bug: T130169
Change-Id: I22f2ca72cf7c2f05f1c0bd7f1acfa30656e50725
---
M src/mixins/FloatableElement.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/58/332758/1
diff --git a/src/mixins/FloatableElement.js b/src/mixins/FloatableElement.js
index 8fa82e5..2161ec8 100644
--- a/src/mixins/FloatableElement.js
+++ b/src/mixins/FloatableElement.js
@@ -86,7 +86,7 @@
closestScrollableOfContainer =
OO.ui.Element.static.getClosestScrollableContainer( this.$floatableContainer[ 0
] );
closestScrollableOfFloatable =
OO.ui.Element.static.getClosestScrollableContainer( this.$floatable[ 0 ] );
- this.needsCustomPosition = closestScrollableOfContainer !==
closestScrollableOfFloatable;
+ this.needsCustomPosition = !OO.ui.contains(
this.$floatableContainer[ 0 ], this.$floatable[ 0 ] );
// If the scrollable is the root, we have to listen to scroll
events
// on the window because of browser inconsistencies.
if ( $( closestScrollableOfContainer ).is( 'html, body' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/332758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22f2ca72cf7c2f05f1c0bd7f1acfa30656e50725
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
