Hello Seb35, jenkins-bot, Tpt, I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/332895 to review the following change. Change subject: Revert "Use the parser to get each template parameter in the Index: namespace" ...................................................................... Revert "Use the parser to get each template parameter in the Index: namespace" This reverts commit cb081bc3c8c31152a87a4e590662b12522ca0204. Bug: T155682 Change-Id: I662b45fe3eea8cad022098582116465676d20c19 --- M includes/index/ProofreadIndexPage.php 1 file changed, 3 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage refs/changes/95/332895/1 diff --git a/includes/index/ProofreadIndexPage.php b/includes/index/ProofreadIndexPage.php index e73716b..fd6f63d 100644 --- a/includes/index/ProofreadIndexPage.php +++ b/includes/index/ProofreadIndexPage.php @@ -235,27 +235,14 @@ * @return array of ProofreadIndexEntry */ public function getIndexEntries() { - global $wgUser, $wgContLang; if ( $this->entries === null ) { $text = $this->getText(); $values = []; - - $parser = self::getParser(); - $options = new ParserOptions( $wgUser, $wgContLang ); - $parser->startExternalParse( $this->title, $options, Parser::OT_PLAIN, true ); - - $dom = $parser->preprocessToDom( $text ); - $frame = $parser->getPreprocessor()->newFrame(); - $dom = $dom->getFirstChild(); - $childframe = $frame->newChild( $dom->getChildrenOfType( 'part' ) ); - foreach ( $this->config as $varName => $property ) { - if ( !array_key_exists( $varName, $childframe->namedArgs ) ) { - continue; + $tagPattern = "/\n\|" . preg_quote( $varName, '/' ) . "=(.*?)\n(\||\}\})/is"; + if ( preg_match( $tagPattern, $text, $matches ) ) { + $values[$varName] = $matches[1]; } - $values[$varName] = $parser->mStripState->unstripBoth( $parser->getPreprocessor()->newFrame()->expand( - $childframe->namedArgs[$varName], PPFrame::RECOVER_ORIG - ) ); } $this->entries = $this->getIndexEntriesFromIndexContent( $values ); } -- To view, visit https://gerrit.wikimedia.org/r/332895 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I662b45fe3eea8cad022098582116465676d20c19 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Seb35 <se...@seb35.fr> Gerrit-Reviewer: Tpt <thoma...@hotmail.fr> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits