Volans has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/333296 )
Change subject: varnishstatsd: temporary fix to avoid crashes
......................................................................
varnishstatsd: temporary fix to avoid crashes
Bug: T151643
Change-Id: I48f8f46b56cc88d633927ebcde1a22c655870ba0
---
M modules/varnish/files/varnishstatsd
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Volans: Looks good to me, approved
diff --git a/modules/varnish/files/varnishstatsd
b/modules/varnish/files/varnishstatsd
index 6778c2d..3e3c9c9 100755
--- a/modules/varnish/files/varnishstatsd
+++ b/modules/varnish/files/varnishstatsd
@@ -55,6 +55,11 @@
def handle_record(self, record):
method, status_code, backend, ttfb = record.split('\t')
+
+ # Temporary fix to avoid crashes
+ if len(ttfb) == 0:
+ return
+
ttfb = round(1000 * float(ttfb))
backend = backend.split('.')[-1]
@@ -81,5 +86,6 @@
self.buf.write(metric_string)
+
if __name__ == "__main__":
StatsdStatsSender(sys.argv[1:]).main()
--
To view, visit https://gerrit.wikimedia.org/r/333296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f8f46b56cc88d633927ebcde1a22c655870ba0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: Ema <e...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
