jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/333349 )

Change subject: Remove uses of 'cols' and 'rows' preferences
......................................................................


Remove uses of 'cols' and 'rows' preferences

The use of 'cols' and 'rows' preferences have been removed from the extension 
PageForms by replacing them with the required values.
The 'editwidth' option has also been removed as it has become obsolete.

Bug: T155153
Change-Id: I967a0c74782a64b71bf8a26c3e0380ff5c269fbd
---
M specials/PF_UploadForm.php
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  TTO: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/PF_UploadForm.php b/specials/PF_UploadForm.php
index 9cc7f64..f640520 100644
--- a/specials/PF_UploadForm.php
+++ b/specials/PF_UploadForm.php
@@ -184,11 +184,6 @@
         * @return array Descriptor array
         */
        protected function getDescriptionSection() {
-               $cols = intval( $this->getUser()->getOption( 'cols' ) );
-               if ( $this->getUser()->getOption( 'editwidth' ) ) {
-                       $this->getOutput()->addInlineStyle( 
'#mw-htmlform-description { width: 100%; }' );
-               }
-
                $descriptor = array(
                        'DestFile' => array(
                                'type' => 'text',
@@ -204,7 +199,7 @@
                                'label-message' => $this->mForReUpload
                                        ? 'filereuploadsummary'
                                        : 'fileuploadsummary',
-                               'cols' => $cols,
+                               'cols' => 80,
                                'rows' => 4,
                        ),
 /*

-- 
To view, visit https://gerrit.wikimedia.org/r/333349
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I967a0c74782a64b71bf8a26c3e0380ff5c269fbd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Amritsreekumar <amrit.sreeku...@gmail.com>
Gerrit-Reviewer: TTO <at.li...@live.com.au>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to