SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333670 )
Change subject: Remove unused wgSupressPageTitle global and duplicate heading
......................................................................
Remove unused wgSupressPageTitle global and duplicate heading
Bug: T143145
Change-Id: Ia35a7f5f7ed3066933729b308514e1bb7e775d97
---
M QuestionGameHome.body.php
M extension.json
2 files changed, 1 insertion(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuizGame
refs/changes/70/333670/1
diff --git a/QuestionGameHome.body.php b/QuestionGameHome.body.php
index 36096ea..c7b3541 100644
--- a/QuestionGameHome.body.php
+++ b/QuestionGameHome.body.php
@@ -38,8 +38,6 @@
* @param $permalink Mixed: parameter passed to the page or null
*/
public function execute( $permalink ) {
- global $wgSupressPageTitle;
-
$out = $this->getOutput();
$user = $this->getUser();
$request = $this->getRequest();
@@ -66,11 +64,6 @@
)
);
}
-
- // Suppress the page title on certain skins of Wikia origin,
such as
- // Nimbus. Yes, the variable name is misspelled but it's all
over the
- // place, so I can't change its name just yet.
- $wgSupressPageTitle = true;
// Add CSS & JS
$out->addModuleStyles( 'ext.quizGame.css' );
@@ -779,10 +772,6 @@
* Present "No more quizzes" message to the user
*/
function renderQuizOver() {
- global $wgSupressPageTitle;
-
- $wgSupressPageTitle = false;
-
$this->getOutput()->setPageTitle( $this->msg(
'quizgame-nomore-questions' )->text() );
$output = $this->msg( 'quizgame-ohnoes' )->parse();
@@ -801,10 +790,6 @@
* Renders the "permalink is not available" error message.
*/
function renderPermalinkError() {
- global $wgSupressPageTitle;
-
- $wgSupressPageTitle = false;
-
$this->getOutput()->setPageTitle( $this->msg( 'quizgame-title'
)->text() );
$this->getOutput()->addWikiMsg( 'quizgame-unavailable' );
}
@@ -1380,8 +1365,6 @@
}
if( $can_create == false ) {
- global $wgSupressPageTitle;
- $wgSupressPageTitle = false;
$out->setPageTitle( $this->msg(
'quizgame-create-threshold-title' )->text() );
$out->addHTML( $this->msg(
'quizgame-create-threshold-reason', $threshold_reason )->parse() );
return '';
@@ -1397,7 +1380,6 @@
$output = '<div id="quiz-container" class="quiz-container">
<div class="create-message">
- <h1>' . $this->msg( 'quizgame-create-title'
)->text() . '</h1>
<p>' . $this->msg( 'quizgame-create-message'
)->parse() . '</p>
<p><input class="site-button" type="button"
onclick="document.location=\'' .
htmlspecialchars(
$this->getPageTitle()->getFullURL( 'questionGameAction=launchGame' ) ) .
diff --git a/extension.json b/extension.json
index 7fe2632..e082a05 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
{
"name": "QuizGame",
- "version": "3.6",
+ "version": "3.7",
"author": [
"Aaron Wright",
"Ashish Datta",
--
To view, visit https://gerrit.wikimedia.org/r/333670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia35a7f5f7ed3066933729b308514e1bb7e775d97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuizGame
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
