SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333674 )
Change subject: Remove unused wgSupressPageTitle global, keep native heading
style
......................................................................
Remove unused wgSupressPageTitle global, keep native heading style
- Keep native heading style instead of rolling out our own custom
CSS for the special page h1 heading
Bug: T143145
Change-Id: I0bc1e4b873db2cdfdd50a181be0a4c036af5a0a9
---
M FanBoxHooks.php
M SpecialFanBoxes.css
M extension.json
3 files changed, 3 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FanBoxes
refs/changes/74/333674/1
diff --git a/FanBoxHooks.php b/FanBoxHooks.php
index 33dad33..286121a 100644
--- a/FanBoxHooks.php
+++ b/FanBoxHooks.php
@@ -41,11 +41,7 @@
* @return Boolean: true
*/
public static function deleteFanBox( &$article, &$user, $reason ) {
- global $wgSupressPageTitle;
-
if ( $article->getTitle()->getNamespace() == NS_FANTAG ) {
- $wgSupressPageTitle = true;
-
$dbw = wfGetDB( DB_MASTER );
$s = $dbw->selectRow(
@@ -127,11 +123,9 @@
* @return Boolean: true
*/
public static function fantagFromTitle( &$title, &$article ) {
- global $wgRequest, $wgOut, $wgSupressPageTitle;
+ global $wgRequest, $wgOut;
if ( $title->getNamespace() == NS_FANTAG ) {
- $wgSupressPageTitle = true;
-
// Add CSS
$wgOut->addModuleStyles( 'ext.fanBoxes' );
@@ -264,4 +258,4 @@
$list[NS_FANTAG_TALK] = 'UserBox_talk';
return true;
}
-}
\ No newline at end of file
+}
diff --git a/SpecialFanBoxes.css b/SpecialFanBoxes.css
index 6d1e674..b156995 100644
--- a/SpecialFanBoxes.css
+++ b/SpecialFanBoxes.css
@@ -23,13 +23,6 @@
width: 550px;
}
-.mw-body h1, .mw-body-primary h1 {
- font-size: 16px;
- margin: 10px 0px 10px 0px !important;
- border-bottom: none;
- font-weight: bold;
-}
-
table.fanBoxTable {
border: 0;
border-collapse: collapse; /* cellspacing=0 equivalent */
diff --git a/extension.json b/extension.json
index afd1ff4..c193b0c 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
{
"name": "FanBoxes",
- "version": "3.2.5",
+ "version": "3.2.6",
"author": [
"Aaron Wright",
"David Pean",
--
To view, visit https://gerrit.wikimedia.org/r/333674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bc1e4b873db2cdfdd50a181be0a4c036af5a0a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FanBoxes
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
