jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/333682 )
Change subject: Remove unused protected method SpecialUserrights::splitGroups
......................................................................
Remove unused protected method SpecialUserrights::splitGroups
Change-Id: I7e06086aab6c939ec4c92887fd8d75ae7c09b860
---
M includes/specials/SpecialUserrights.php
1 file changed, 0 insertions(+), 23 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialUserrights.php
b/includes/specials/SpecialUserrights.php
index 98cdc09..b1f8a17 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -472,29 +472,6 @@
}
/**
- * Go through used and available groups and return the ones that this
- * form will be able to manipulate based on the current user's system
- * permissions.
- *
- * @param array $groups List of groups the given user is in
- * @return array Tuple of addable, then removable groups
- */
- protected function splitGroups( $groups ) {
- list( $addable, $removable, $addself, $removeself ) =
array_values( $this->changeableGroups() );
-
- $removable = array_intersect(
- array_merge( $this->isself ? $removeself : [],
$removable ),
- $groups
- ); // Can't remove groups the user doesn't have
- $addable = array_diff(
- array_merge( $this->isself ? $addself : [], $addable ),
- $groups
- ); // Can't add groups the user does have
-
- return [ $addable, $removable ];
- }
-
- /**
* Show the form to edit group memberships.
*
* @param User|UserRightsProxy $user User or UserRightsProxy you're
editing
--
To view, visit https://gerrit.wikimedia.org/r/333682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e06086aab6c939ec4c92887fd8d75ae7c09b860
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
