Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334348 )
Change subject: Ensure that keyboard is hidden after editing description.
......................................................................
Ensure that keyboard is hidden after editing description.
After a lot (a *lot*) of trial and error, this is the least amount of code
necessary to ensure that the soft keyboard gets hidden upon a successful
description edit, on all APIs and vendors that I've tested.
Change-Id: I377eb8ae3bbde6d8aa1be4045f7f8ff4d5666977
---
M app/src/main/AndroidManifest.xml
M app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.java
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/48/334348/1
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 52776f5..64dcb70 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -153,7 +153,7 @@
<activity android:name=".descriptions.DescriptionEditActivity"
android:theme="@style/AppTheme"
- android:windowSoftInputMode="stateVisible|adjustResize" />
+ android:windowSoftInputMode="adjustResize" />
<activity android:name=".descriptions.DescriptionEditSuccessActivity"
android:theme="@style/AppTheme.TranslucentDark"
diff --git
a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.java
b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.java
index d67c2d3..57f66fb 100644
--- a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.java
+++ b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.java
@@ -25,7 +25,6 @@
import org.wikipedia.login.User;
import org.wikipedia.page.PageTitle;
import org.wikipedia.settings.Prefs;
-import org.wikipedia.util.DeviceUtil;
import org.wikipedia.util.log.L;
import java.util.Date;
@@ -63,7 +62,6 @@
if (getActivity() == null) {
return;
}
- DeviceUtil.hideSoftKeyboard(getActivity());
editView.setSaveState(false);
startActivityForResult(DescriptionEditSuccessActivity.newIntent(getContext()),
Constants.ACTIVITY_REQUEST_DESCRIPTION_EDIT_SUCCESS);
--
To view, visit https://gerrit.wikimedia.org/r/334348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I377eb8ae3bbde6d8aa1be4045f7f8ff4d5666977
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
