jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334417 )
Change subject: Remove MobileFrontend toast dependency
......................................................................
Remove MobileFrontend toast dependency
Rather than using mobile.startup, switch
to using mediawiki.notification which is more
lightweight and does same thing.
Bug: T155801
Change-Id: I23d75272602766e24e8b01410f4a88609eda6dee
---
M extension.json
M modules/ext.thanks.mobilediff.js
2 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 907cd62..ada16a9 100644
--- a/extension.json
+++ b/extension.json
@@ -99,7 +99,7 @@
],
"dependencies": [
"mediawiki.api",
- "mobile.toast"
+ "mediawiki.notification"
],
"targets": [
"desktop",
diff --git a/modules/ext.thanks.mobilediff.js b/modules/ext.thanks.mobilediff.js
index 9faec3a..6761d11 100644
--- a/modules/ext.thanks.mobilediff.js
+++ b/modules/ext.thanks.mobilediff.js
@@ -1,6 +1,4 @@
( function ( mw, M, $ ) {
- var popup = M.require( 'mobile.toast/toast' );
-
/**
* Create a thank button for a given edit
*
@@ -15,7 +13,7 @@
rev: revision,
source: 'mobilediff'
} ).done( function () {
- popup.show( mw.msg( 'thanks-thanked-notice', name,
gender ) );
+ mw.notify( mw.msg( 'thanks-thanked-notice', name,
gender ) );
d.resolve();
} )
.fail( function ( errorCode ) {
--
To view, visit https://gerrit.wikimedia.org/r/334417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23d75272602766e24e8b01410f4a88609eda6dee
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
