jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/334443 )
Change subject: Do not downscale the chrome header logo/align it vertically ...................................................................... Do not downscale the chrome header logo/align it vertically Use copyright-width and copyright-height instead from $wgMFCustomLogos to avoid issues with vertical alignment Use line-height to make sure alignment is correct Bug: T152458 Change-Id: Ide681b9e17cbcf1be7870961d1b2eabda45f172b --- M README.md M resources/skins.minerva.base.styles/ui.less 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Bmansurov: Looks good to me, approved jenkins-bot: Verified diff --git a/README.md b/README.md index 93f5359..e34e7dc 100644 --- a/README.md +++ b/README.md @@ -511,7 +511,7 @@ Currently, `copyright`, `copyright-width`, and `copyright-height` elements are supported. -* `copyright` is the URL of the logo displayed in the footer +* `copyright` is the URL of the logo displayed in the header and footer * `copyright-width` (optional) is the width in pixels of the copyright image you want to display * `copyright-height` (optional) is the height in pixels of the copyright image @@ -519,6 +519,8 @@ * If the actual `copyright` dimensions are 200x30, then you may want to set the width and height to 100 and 15 respectively (in order to support retina screens). +* Note that if -width and -height are not used sysadmin should ensure the image +used is appropriately sized (suggested dimensions < 120px width and 18px height). Example: ```php diff --git a/resources/skins.minerva.base.styles/ui.less b/resources/skins.minerva.base.styles/ui.less index 2710363..46708a1 100644 --- a/resources/skins.minerva.base.styles/ui.less +++ b/resources/skins.minerva.base.styles/ui.less @@ -127,12 +127,11 @@ font-size: 1em; span { - font-size: 1.25em; + line-height: 1; + font-size: inherit; } img { - height: 18px; - width: auto; vertical-align: middle; } -- To view, visit https://gerrit.wikimedia.org/r/334443 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide681b9e17cbcf1be7870961d1b2eabda45f172b Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: branding Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits