jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/334416 )

Change subject: Token is not always set in diff
......................................................................


Token is not always set in diff

Replicated this on a local instance while logged in and visiting
a diff page where I wasn't the author of the diff.

Bug: T151837
Change-Id: Ie541c717a9c4103e39eecac77bcdb45a7ebad74e
---
M includes/diff/InlineDifferenceEngine.php
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/includes/diff/InlineDifferenceEngine.php 
b/includes/diff/InlineDifferenceEngine.php
index 8fdd364..ad36ca9 100644
--- a/includes/diff/InlineDifferenceEngine.php
+++ b/includes/diff/InlineDifferenceEngine.php
@@ -160,13 +160,12 @@
                $linkInfo = $this->getMarkPatrolledLinkInfo();
                if ( $linkInfo ) {
                        $this->getOutput()->addModules( 'mobile.patrol.ajax' );
+
                        $linkInfo = Html::linkButton(
                                $this->msg( 'markaspatrolleddiff' )->escaped(),
                                [
-                                       'href' => $this->mNewPage->getLocalUrl( 
[
+                                       'href' => $this->mNewPage->getLocalUrl( 
$linkInfo + [
                                                'action' => 'markpatrolled',
-                                               'rcid' => $linkInfo['rcid'],
-                                               'token' => $linkInfo['token'],
                                        ] ),
                                ]
                        );

-- 
To view, visit https://gerrit.wikimedia.org/r/334416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie541c717a9c4103e39eecac77bcdb45a7ebad74e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to