Daniel Werner has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50186
Change subject: Gives names to all important constructors for improved
debugging experience
......................................................................
Gives names to all important constructors for improved debugging experience
Change-Id: I3a7eb9a910d8080b1244f5b989b4ba4ec0cda7be
---
M DataTypes/resources/dataTypes.js
M DataValues/resources/DataValue.js
M DataValues/resources/dataValues.js
M DataValues/resources/values/BoolValue.js
M DataValues/resources/values/MonolingualTextValue.js
M DataValues/resources/values/MultilingualTextValue.js
M DataValues/resources/values/NumberValue.js
M DataValues/resources/values/StringValue.js
M DataValues/resources/values/UnknownValue.js
M ValueParsers/resources/Api.js
M ValueParsers/resources/ApiBasedValueParser.js
M ValueParsers/resources/ValueParser.js
M ValueParsers/resources/ValueParserFactory.js
13 files changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/86/50186/1
diff --git a/DataTypes/resources/dataTypes.js b/DataTypes/resources/dataTypes.js
index e0a4958..28d772a 100644
--- a/DataTypes/resources/dataTypes.js
+++ b/DataTypes/resources/dataTypes.js
@@ -15,7 +15,7 @@
* @since 0.1
* @type Object
*/
-var dataTypes = new ( function( $, mw, undefined ) {
+var dataTypes = new ( function Dt( $, mw ) {
'use strict';
// TODO: the whole structure of this is a little weird, perhaps there
should be a
@@ -37,7 +37,7 @@
* @param {Object} formatter
* @param {Object} validators
*/
- dt.DataType = function( typeId, dataValueType, parser, formatter,
validators ) {
+ dt.DataType = function DtDataType( typeId, dataValueType, parser,
formatter, validators ) {
if( dataValueType === undefined ) {
throw new Error( 'All arguments must be provided for
creating a new DataType object' );
}
diff --git a/DataValues/resources/DataValue.js
b/DataValues/resources/DataValue.js
index 7c42a50..164d3a7 100644
--- a/DataValues/resources/DataValue.js
+++ b/DataValues/resources/DataValue.js
@@ -15,7 +15,7 @@
* @abstract
* @since 0.1
*/
-dv.DataValue = function() {};
+dv.DataValue = function DvDataValue() {};
dv.DataValue.prototype = {
/**
diff --git a/DataValues/resources/dataValues.js
b/DataValues/resources/dataValues.js
index 6422367..6886a22 100644
--- a/DataValues/resources/dataValues.js
+++ b/DataValues/resources/dataValues.js
@@ -14,7 +14,7 @@
* @since 0.1
* @type Object
*/
-var dataValues = new( function( $, undefined ) {
+var dataValues = new( function Dv( $ ) {
'use strict';
var dvs = [];
diff --git a/DataValues/resources/values/BoolValue.js
b/DataValues/resources/values/BoolValue.js
index 1af21b9..462a325 100644
--- a/DataValues/resources/values/BoolValue.js
+++ b/DataValues/resources/values/BoolValue.js
@@ -24,7 +24,7 @@
*
* @param {String} value
*/
-dv.BoolValue = dv.util.inherit( PARENT, constructor, {
+dv.BoolValue = dv.util.inherit( 'DvBoolValue', PARENT, constructor, {
/**
* @see dv.DataValue.getSortKey
diff --git a/DataValues/resources/values/MonolingualTextValue.js
b/DataValues/resources/values/MonolingualTextValue.js
index cf60fec..36a1e4a 100644
--- a/DataValues/resources/values/MonolingualTextValue.js
+++ b/DataValues/resources/values/MonolingualTextValue.js
@@ -5,7 +5,7 @@
* @author Daniel Werner
* @author Jeroen De Dauw < [email protected] >
*/
-( function( dv, $, undefined ) {
+( function( dv, $ ) {
'use strict';
var PARENT = dv.DataValue,
@@ -26,7 +26,7 @@
* @param {String} languageCode
* @param {String} value
*/
-dv.MonolingualTextValue = dv.util.inherit( PARENT, constructor, {
+dv.MonolingualTextValue = dv.util.inherit( 'DvMonolingualTextValue', PARENT,
constructor, {
/**
* @see dv.DataValue.getSortKey
diff --git a/DataValues/resources/values/MultilingualTextValue.js
b/DataValues/resources/values/MultilingualTextValue.js
index 631967b..f062018 100644
--- a/DataValues/resources/values/MultilingualTextValue.js
+++ b/DataValues/resources/values/MultilingualTextValue.js
@@ -5,7 +5,7 @@
* @author Jeroen De Dauw < [email protected] >
* @author Daniel Werner
*/
-( function( dv, $, undefined ) {
+( function( dv, $ ) {
'use strict';
var PARENT = dv.DataValue,
@@ -24,7 +24,7 @@
*
* @param {dv.MonolingualTextValue[]} monoLingualValues
*/
-dv.MultilingualTextValue = dv.util.inherit( PARENT, constructor, {
+dv.MultilingualTextValue = dv.util.inherit( 'DvMultilingualTextValue', PARENT,
constructor, {
/**
* @see dv.DataValue.getSortKey
diff --git a/DataValues/resources/values/NumberValue.js
b/DataValues/resources/values/NumberValue.js
index b04a2ed..b0071df 100644
--- a/DataValues/resources/values/NumberValue.js
+++ b/DataValues/resources/values/NumberValue.js
@@ -6,7 +6,7 @@
*
* @author Daniel Werner < [email protected] >
*/
-( function( dv, $, undefined ) {
+( function( dv, $ ) {
'use strict';
var PARENT = dv.DataValue,
@@ -24,7 +24,7 @@
*
* @param {Number} value
*/
- dv.NumberValue = dv.util.inherit( PARENT, constructor, {
+ dv.NumberValue = dv.util.inherit( 'DvNumberValue', PARENT, constructor,
{
/**
* @see dv.DataValue.getSortKey
*
diff --git a/DataValues/resources/values/StringValue.js
b/DataValues/resources/values/StringValue.js
index 4eac002..d7e094c 100644
--- a/DataValues/resources/values/StringValue.js
+++ b/DataValues/resources/values/StringValue.js
@@ -7,7 +7,7 @@
* @author Daniel Werner
* @author Jeroen De Dauw < [email protected] >
*/
-( function( dv, $, undefined ) {
+( function( dv, $ ) {
'use strict';
var PARENT = dv.DataValue,
@@ -25,7 +25,7 @@
*
* @param {String} value
*/
-dv.StringValue = dv.util.inherit( PARENT, constructor, {
+dv.StringValue = dv.util.inherit( 'StringValue', PARENT, constructor, {
/**
* @see dv.DataValue.getSortKey
diff --git a/DataValues/resources/values/UnknownValue.js
b/DataValues/resources/values/UnknownValue.js
index 433e7da..ad2c308 100644
--- a/DataValues/resources/values/UnknownValue.js
+++ b/DataValues/resources/values/UnknownValue.js
@@ -24,7 +24,7 @@
*
* @param {String} value
*/
- dv.UnknownValue = dv.util.inherit( PARENT, constructor, {
+ dv.UnknownValue = dv.util.inherit( 'DvUnknownValue', PARENT,
constructor, {
/**
* @see dv.DataValue.getSortKey
diff --git a/ValueParsers/resources/Api.js b/ValueParsers/resources/Api.js
index c7d459b..45f70b6 100644
--- a/ValueParsers/resources/Api.js
+++ b/ValueParsers/resources/Api.js
@@ -4,7 +4,7 @@
* @licence GNU GPL v2+
* @author Jeroen De Dauw < [email protected] >
*/
-( function( mw, vp, $, dv, undefined ) {
+( function( mw, vp, $, dv ) {
'use strict';
/**
diff --git a/ValueParsers/resources/ApiBasedValueParser.js
b/ValueParsers/resources/ApiBasedValueParser.js
index 1b5e64a..a82ba30 100644
--- a/ValueParsers/resources/ApiBasedValueParser.js
+++ b/ValueParsers/resources/ApiBasedValueParser.js
@@ -6,7 +6,7 @@
*
* @author Daniel Werner < [email protected] >
*/
-( function( vp, dv, $, undefined ) {
+( function( vp, dv, $ ) {
'use strict';
var PARENT = vp.ValueParser;
@@ -20,7 +20,7 @@
* @abstract
* @since 0.1
*/
- vp.ApiBasedValueParser = dv.util.inherit( PARENT, {
+ vp.ApiBasedValueParser = dv.util.inherit( 'VpApiBasedValueParser',
PARENT, {
/**
* The key of the related API parser.
* @type String
diff --git a/ValueParsers/resources/ValueParser.js
b/ValueParsers/resources/ValueParser.js
index 50efb4d..857e54b 100644
--- a/ValueParsers/resources/ValueParser.js
+++ b/ValueParsers/resources/ValueParser.js
@@ -16,7 +16,7 @@
*
* @param {Object} options
*/
- vp.ValueParser = function( options ) {
+ vp.ValueParser = function VpValueParser( options ) {
this._options = options || {};
};
diff --git a/ValueParsers/resources/ValueParserFactory.js
b/ValueParsers/resources/ValueParserFactory.js
index 55e844d..fd7e88e 100644
--- a/ValueParsers/resources/ValueParserFactory.js
+++ b/ValueParsers/resources/ValueParserFactory.js
@@ -14,7 +14,7 @@
*
* @param {Object} valueParsers
*/
- vp.ValueParserFactory = function( valueParsers ) {
+ vp.ValueParserFactory = function VpValueParserFactory( valueParsers ) {
this._parsers = {};
for ( var parserId in valueParsers ) {
--
To view, visit https://gerrit.wikimedia.org/r/50186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a7eb9a910d8080b1244f5b989b4ba4ec0cda7be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
