MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50194
Change subject: Fix some minor bugs in the link neighbour code
......................................................................
Fix some minor bugs in the link neighbour code
The traverser will now use Node:firstChild and Node:nextSibling to
traverse, and our link neighbour handler will now bail out correctly
if it's handling a non-wikilink link.
Change-Id: I736b794a2b916350c148f419b5153190fcaecbcf
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/94/50194/1
diff --git a/js/lib/mediawiki.DOMPostProcessor.js
b/js/lib/mediawiki.DOMPostProcessor.js
index 34b419c..6bd0e74 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -115,12 +115,12 @@
* Traverse the DOM and fire the handlers that are registered
*/
DOMTraverser.prototype.traverse = function ( node ) {
- var ix, child, childDT, children = node.childNodes;
+ var childDT, child = node.firstChild;
- for ( ix = 0; children && ix < children.length; ix++ ) {
- child = children[ix];
+ while ( child !== null ) {
this.callHandlers( child );
this.traverse( child );
+ child = child.nextSibling;
}
};
@@ -2159,14 +2159,14 @@
* Workhorse function for bringing linktrails and link prefixes into link
content.
*/
function handleLinkNeighbours( env, node ) {
- var ix, prefix = getLinkPrefix( env, node ),
- trail = getLinkTrail( env, node ),
- dp = Util.getJSONAttribute( node, 'data-parsoid', {} );
-
if ( node.getAttribute( 'rel' ) !== 'mw:WikiLink' ) {
return;
}
+ var ix, prefix = getLinkPrefix( env, node ),
+ trail = getLinkTrail( env, node ),
+ dp = Util.getJSONAttribute( node, 'data-parsoid', {} );
+
if ( prefix && prefix.content ) {
for ( ix = 0; ix < prefix.content.length; ix++ ) {
node.insertBefore( prefix.content[ix], node.firstChild
);
--
To view, visit https://gerrit.wikimedia.org/r/50194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I736b794a2b916350c148f419b5153190fcaecbcf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
