jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/334869 )

Change subject: parser test editor: Fix emitting of !! hooks
......................................................................


parser test editor: Fix emitting of !! hooks

The first newline was missing so a block like:
 !! hooks
 source
 !! endhooks

would turn into:
 !! hookssource
 !! endhooks

Change-Id: I2a4c5e52050d55fb0c9b4f5d0494eb00e34b233c
---
M tests/parser/TestFileEditor.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tim Starling: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/parser/TestFileEditor.php b/tests/parser/TestFileEditor.php
index 05b1216..7f64671 100644
--- a/tests/parser/TestFileEditor.php
+++ b/tests/parser/TestFileEditor.php
@@ -125,7 +125,7 @@
                $line = $this->lines[$this->pos++];
                $heading = $this->getHeading( $line );
                $expectedEnd = 'end' . $heading;
-               $contents = $line;
+               $contents = "$line\n";
 
                do {
                        $line = $this->lines[$this->pos++];

-- 
To view, visit https://gerrit.wikimedia.org/r/334869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a4c5e52050d55fb0c9b4f5d0494eb00e34b233c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to