jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334909 )
Change subject: Remove .join( '|' ) for API parameters
......................................................................
Remove .join( '|' ) for API parameters
mw.Api automatically joins parameters which are from type array.
Change-Id: Ic56ec9936a6ac4dcfe575341c064f4dae40ffbca
---
M modules/dashboard/ext.cx.suggestionlist.js
M modules/dashboard/ext.cx.translationlist.js
M modules/publish/ext.cx.publish.js
M modules/tools/ext.cx.tools.categories.js
M modules/tools/ext.cx.tools.link.js
M modules/widgets/pageselector/ext.cx.pageselector.js
6 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/modules/dashboard/ext.cx.suggestionlist.js
b/modules/dashboard/ext.cx.suggestionlist.js
index 526467b..15faf79 100644
--- a/modules/dashboard/ext.cx.suggestionlist.js
+++ b/modules/dashboard/ext.cx.suggestionlist.js
@@ -291,8 +291,8 @@
CXSuggestionList.prototype.getPageDetails = function ( language, titles
) {
return this.siteMapper.getApi( language ).get( {
action: 'query',
- titles: titles.join( '|' ),
- prop: [ 'pageimages', 'pageterms' ].join( '|' ),
+ titles: titles,
+ prop: [ 'pageimages', 'pageterms' ],
piprop: 'thumbnail',
pilimit: 50, // maximum
pithumbsize: 100,
diff --git a/modules/dashboard/ext.cx.translationlist.js
b/modules/dashboard/ext.cx.translationlist.js
index a1868c1..ec3e459 100644
--- a/modules/dashboard/ext.cx.translationlist.js
+++ b/modules/dashboard/ext.cx.translationlist.js
@@ -123,7 +123,7 @@
CXTranslationList.prototype.getLinkImages = function ( language, titles
) {
return this.siteMapper.getApi( language ).get( {
action: 'query',
- titles: titles.join( '|' ),
+ titles: titles,
prop: 'pageimages',
piprop: 'thumbnail',
pilimit: 50, // maximum
diff --git a/modules/publish/ext.cx.publish.js
b/modules/publish/ext.cx.publish.js
index 7eda0ff..47da28d 100644
--- a/modules/publish/ext.cx.publish.js
+++ b/modules/publish/ext.cx.publish.js
@@ -40,7 +40,7 @@
to: mw.cx.targetLanguage,
sourcetitle: mw.cx.sourceTitle,
html: EasyDeflate.deflate( self.getContent() ),
- categories: this.getCategories().join( '|' )
+ categories: this.getCategories()
} );
return this.checkTargetTitle( this.targetTitle ).then( function
( title ) {
diff --git a/modules/tools/ext.cx.tools.categories.js
b/modules/tools/ext.cx.tools.categories.js
index ab7a7db..db3a06a 100644
--- a/modules/tools/ext.cx.tools.categories.js
+++ b/modules/tools/ext.cx.tools.categories.js
@@ -560,7 +560,7 @@
this.siteMapper.getApi( mw.cx.sourceLanguage ).post( {
action: 'query',
- titles: categoryTitles.join( '|' ),
+ titles: categoryTitles,
prop: 'langlinks',
lllang: this.siteMapper.getWikiDomainCode( language ),
lllimit: 100,
diff --git a/modules/tools/ext.cx.tools.link.js
b/modules/tools/ext.cx.tools.link.js
index 4dff768..74831f8 100644
--- a/modules/tools/ext.cx.tools.link.js
+++ b/modules/tools/ext.cx.tools.link.js
@@ -74,7 +74,7 @@
mw.cx.siteMapper.getApi( apiLanguage ).get( {
action: 'query',
- titles: titles.join( '|' ),
+ titles: titles,
prop: 'langlinks',
lllimit: titles.length, // TODO: Default is 10 and max
is 500. Do we need more than 500?
lllang: mw.cx.siteMapper.getWikiDomainCode( language ),
diff --git a/modules/widgets/pageselector/ext.cx.pageselector.js
b/modules/widgets/pageselector/ext.cx.pageselector.js
index 7d4d06d..8988a72 100644
--- a/modules/widgets/pageselector/ext.cx.pageselector.js
+++ b/modules/widgets/pageselector/ext.cx.pageselector.js
@@ -59,7 +59,7 @@
generator: 'prefixsearch',
gpssearch: input,
gpslimit: 10,
- prop: [ 'pageimages', 'pageterms' ].join( '|' ),
+ prop: [ 'pageimages', 'pageterms' ],
piprop: 'thumbnail',
pithumbsize: 50,
pilimit: 10,
--
To view, visit https://gerrit.wikimedia.org/r/334909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic56ec9936a6ac4dcfe575341c064f4dae40ffbca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Fomafix <[email protected]>
Gerrit-Reviewer: Fomafix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
