Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334278 )
Change subject: deployment: Linting fixes
......................................................................
deployment: Linting fixes
Use full names for class names, as relative names are not allowed in
future Puppet versions
Add trailing commas to abide by the Coding Style guidelines
Bug: T93645
Change-Id: If8e28cd43be46ef7490c7835caf8c3d69f4c12b3
---
M modules/deployment/manifests/redis.pp
M modules/deployment/manifests/rsync.pp
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/deployment/manifests/redis.pp
b/modules/deployment/manifests/redis.pp
index b8d3139..28528ea 100644
--- a/modules/deployment/manifests/redis.pp
+++ b/modules/deployment/manifests/redis.pp
@@ -18,14 +18,14 @@
slave_read_only => true,
slaveof => "${deployment_ipv4} 6379",
bind => '0.0.0.0',
- }
+ },
}
} else {
redis::instance{ 6379:
settings => {
daemonize => $daemonize_redis,
bind => '0.0.0.0',
- }
+ },
}
}
}
diff --git a/modules/deployment/manifests/rsync.pp
b/modules/deployment/manifests/rsync.pp
index 8ab02cc..ff41772 100644
--- a/modules/deployment/manifests/rsync.pp
+++ b/modules/deployment/manifests/rsync.pp
@@ -4,7 +4,7 @@
#
class deployment::rsync($deployment_server, $cron_ensure='absent') {
- include rsync::server
+ include ::rsync::server
rsync::server::module { 'trebuchet_server':
path => '/srv/deployment',
--
To view, visit https://gerrit.wikimedia.org/r/334278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8e28cd43be46ef7490c7835caf8c3d69f4c12b3
Gerrit-PatchSet: 6
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Juniorsys <juniorsys_wikime...@outlook.com>
Gerrit-Reviewer: ArielGlenn <ar...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Ryan Lane <r...@ryandlane.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
