jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/333694 )
Change subject: Fix an issue that prevented sign-up form working in Chrome
......................................................................
Fix an issue that prevented sign-up form working in Chrome
The reason field was marked as required. Perhaps due to changes
in Chrome this started preventing the form submission. Only
mark it required when it is visible.
Change-Id: I03769cfbbeaaa882395506dd8df670aa01a132fa
---
M resources/js/ext.translate.mainpage.signup.js
M specials/SpecialTwnMainPage.php
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Amire80: Looks good to me, approved
Nemo bis: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.mainpage.signup.js
b/resources/js/ext.translate.mainpage.signup.js
index 6cee1fd..9572fc8 100644
--- a/resources/js/ext.translate.mainpage.signup.js
+++ b/resources/js/ext.translate.mainpage.signup.js
@@ -10,13 +10,15 @@
mw.translate.setupSignupForm = function ( $form ) {
var $username = $form.find( 'input[name="wpName"]' ),
$email = $form.find( 'input[name="wpEmail"]' ),
- $password = $form.find( 'input[name="wpPassword"]' );
+ $password = $form.find( 'input[name="wpPassword"]' ),
+ $reason = $form.find( 'input[name="reason"]' );
function initDeveloperSignup() {
$form.find( '.dev-signup' ).click( function () {
$form.find( '.only-dev' ).removeClass( 'hide' );
$form.find( '.only-nondev' ).addClass( 'hide' );
$form.find( '.required' ).trigger( 'change' );
+ $reason.prop( 'required', true );
} );
$form.find( 'button.cancel' ).click( function ( e ) {
@@ -24,6 +26,7 @@
$form.find( '.only-dev' ).addClass( 'hide' );
$form.find( '.only-nondev' ).removeClass(
'hide' );
$form.find( '.required' ).trigger( 'change' );
+ $reason.prop( 'required', false );
} );
}
diff --git a/specials/SpecialTwnMainPage.php b/specials/SpecialTwnMainPage.php
index 9aa830a..6ad411a 100644
--- a/specials/SpecialTwnMainPage.php
+++ b/specials/SpecialTwnMainPage.php
@@ -574,7 +574,6 @@
'class' => 'twelve columns required',
'name' => 'reason',
'rows' => '4',
- 'required',
] );
$contents = <<<HTML
--
To view, visit https://gerrit.wikimedia.org/r/333694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03769cfbbeaaa882395506dd8df670aa01a132fa
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
