jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334888 )
Change subject: Move description from extension.json to message file
......................................................................
Move description from extension.json to message file
Added i18n files and banana check
Change-Id: I0ba1167bc347c6fd83a8503ad82212afd05e181e
---
A .gitignore
M D3Loader.php
A Gruntfile.js
A i18n/en.json
A i18n/qqq.json
A package.json
6 files changed, 45 insertions(+), 1 deletion(-)
Approvals:
Raimond Spekking: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..7e5da87
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,2 @@
+node_modules/
+vendor/
diff --git a/D3Loader.php b/D3Loader.php
index 441f1a3..589eea0 100644
--- a/D3Loader.php
+++ b/D3Loader.php
@@ -34,10 +34,12 @@
'name' => 'D3Loader',
'author' => 'Leonid Verhovskij',
'url' => 'https://www.mediawiki.org/wiki/Extension:D3Loader',
- 'description' => 'This Extension simply load D3.js to make it available
for other extensions',
+ 'descriptionmsg' => 'd3loader-desc',
'version' => 1.0
);
+$wgMessagesDirs['D3Loader'] = __DIR__ . '/i18n';
+
$myResourceTemplate = array(
'localBasePath' => __DIR__ . '/resources',
'remoteExtPath' => 'D3Loader/resources',
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..a45071e
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,21 @@
+/*jshint node:true */
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ grunt.initConfig( {
+ banana: {
+ all: 'i18n/'
+ },
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/i18n/en.json b/i18n/en.json
new file mode 100644
index 0000000..13e49c0
--- /dev/null
+++ b/i18n/en.json
@@ -0,0 +1,4 @@
+{
+ "@metadata": {},
+ "d3loader-desc": "Loads D3.js for use by other extensions"
+}
diff --git a/i18n/qqq.json b/i18n/qqq.json
new file mode 100644
index 0000000..bbfb56d
--- /dev/null
+++ b/i18n/qqq.json
@@ -0,0 +1,4 @@
+{
+ "@metadata": {},
+ "d3loader-desc":
"{{desc|name=D3Loader|url=https://www.mediawiki.org/wiki/Extension:D3Loader}}";
+}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..bcf5b13
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.5.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/334888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ba1167bc347c6fd83a8503ad82212afd05e181e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/D3Loader
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Raimond Spekking <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
