Matthias Mullie has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335427 )
Change subject: Cut out old code & improve firefogg-nonascii error message
......................................................................
Cut out old code & improve firefogg-nonascii error message
this.upload.setError & this.upload.ui.setStatus are no longer
needed: simply rejecting the deferred is all that is needed &
that error result will be dealt with elsewhere.
Change-Id: Iaa5b146e4570649adfeb146dcd91c125291730b6
---
M resources/handlers/mw.FirefoggHandler.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/27/335427/1
diff --git a/resources/handlers/mw.FirefoggHandler.js
b/resources/handlers/mw.FirefoggHandler.js
index 5568d3a..d0ad899 100644
--- a/resources/handlers/mw.FirefoggHandler.js
+++ b/resources/handlers/mw.FirefoggHandler.js
@@ -61,12 +61,10 @@
// Bail on non-ASCII filenames
// eslint-disable-next-line no-control-regex
if ( !this.upload.title || !( /^[\x00-\x7F]*$/.test(
this.upload.title.getMain() ) ) ) {
- this.upload.setError( 'firefogg-nonascii', '' );
- this.upload.ui.setStatus(
'mwe-upwiz-firefogg-nonascii' );
return $.Deferred().reject( 'firefogg', {
error: {
code: 'firefogg',
- html: mw.message(
'api-error-firefogg' ).parse()
+ html: mw.message(
'mwe-upwiz-firefogg-nonascii' ).parse()
}
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/335427
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa5b146e4570649adfeb146dcd91c125291730b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
