JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50275
Change subject: Add photo upload support for Firefox
......................................................................
Add photo upload support for Firefox
And possibly any other browser that supports FormData and FileReader.
Change-Id: Id54befc5c5aab662d9a1b9eaf170b5f9c4a75a77
---
M javascripts/modules/mf-photo.js
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/75/50275/1
diff --git a/javascripts/modules/mf-photo.js b/javascripts/modules/mf-photo.js
index edb2e29..c765086 100644
--- a/javascripts/modules/mf-photo.js
+++ b/javascripts/modules/mf-photo.js
@@ -18,9 +18,7 @@
function isSupported() {
// FIXME: create a module for browser detection stuff
var browserSupported = (
- typeof FileReader !== 'undefined' && typeof FormData
!== 'undefined' &&
- // webkit only for time being
- window.navigator.userAgent.indexOf( 'WebKit' ) > -1
+ typeof FileReader !== 'undefined' && typeof FormData
!== 'undefined'
);
return (
@@ -87,7 +85,10 @@
formData.append( 'format', 'json' );
// send useformat=mobile for sites where
endpoint is a desktop url so that they are mobile edit tagged
formData.append( 'useformat', 'mobile' );
- formData.append( 'origin', M.getOrigin() );
+ // add origin only when doing CORS
+ if ( endpoint ) {
+ formData.append( 'origin',
M.getOrigin() );
+ }
formData.append( 'filename', options.fileName );
formData.append( 'comment', mw.msg(
options.editSummaryMessage ) );
formData.append( 'file', options.file );
@@ -164,7 +165,9 @@
// make license links open in separate tabs
this.$( '.license a' ).attr( 'target', '_blank' );
- $description.on( 'keyup', function() {
+ // use input event too, Firefox doesn't fire keyup on
many devices:
+ // https://bugzilla.mozilla.org/show_bug.cgi?id=737658
+ $description.on( 'keyup input', function() {
if ( $description.val() ) {
$submitButton.removeAttr( 'disabled' );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/50275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id54befc5c5aab662d9a1b9eaf170b5f9c4a75a77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
