Divec has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335641 )
Change subject: Check correctly whether the cursor crossed a preunicorn
......................................................................
Check correctly whether the cursor crossed a preunicorn
Without this fix, cursoring isn't correctly broken when cursoring backwards at
the
beginning of a paragraph (this subtle bug masks the more obvious one in T157019)
Bug: T157019
Change-Id: I43cf181231e21d8cef56d9ce70cfeeb6e35c8088
---
M src/ce/ve.ce.Surface.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/41/335641/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index fa77314..020c0a8 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1527,8 +1527,9 @@
range.endOffset,
preUnicorn.parentNode,
ve.parentIndex( preUnicorn )
- ) < 0 ) {
- // before the pre-unicorn
+ ) <= 0 ) {
+ // before the pre-unicorn (including in the equality case,
because the selection
+ // endpoint is an offset between sibling positions)
fixup = -1;
} else {
// at or after the pre-unicorn (actually must be after the
post-unicorn)
--
To view, visit https://gerrit.wikimedia.org/r/335641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43cf181231e21d8cef56d9ce70cfeeb6e35c8088
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
