jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/335622 )
Change subject: Limit metric names
......................................................................
Limit metric names
Looking in graphite there are currently a few metrics that
have appeared due to malformed URLs.
Change-Id: I51cb17afe46a5faf95006e43c4bb0f6b21d335b8
---
M src/specials/SpecialElectronPdf.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/specials/SpecialElectronPdf.php
b/src/specials/SpecialElectronPdf.php
index af37df0..954f228 100644
--- a/src/specials/SpecialElectronPdf.php
+++ b/src/specials/SpecialElectronPdf.php
@@ -42,16 +42,18 @@
$action = $request->getVal( 'action', 'default' );
$stats =
MediaWikiServices::getInstance()->getStatsdDataFactory();
- $stats->increment( 'electronpdf.action.' . $action );
switch ( $action ) {
case 'redirect-to-electron':
+ $stats->increment( 'electronpdf.action.' .
$action );
$this->redirectToElectron( $title );
return;
case 'redirect-to-collection':
+ $stats->increment( 'electronpdf.action.' .
$action );
$this->redirectToCollection(
$collectionDownloadUrl );
return;
default:
+ $stats->increment(
'electronpdf.action.show-selection-screen' );
$this->showRenderModeSelectionPage( $title,
$collectionDownloadUrl );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/335622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51cb17afe46a5faf95006e43c4bb0f6b21d335b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ElectronPdfService
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
