jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/335248 )
Change subject: Remove WikEdDiff logging code
......................................................................
Remove WikEdDiff logging code
Change-Id: I898234d72f496d0ce7299f18c121faf2fe174645
---
M modules/ext.RevisionSlider.DiffPage.js
1 file changed, 0 insertions(+), 16 deletions(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.DiffPage.js
b/modules/ext.RevisionSlider.DiffPage.js
index f225b73..32c4f39 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -1,6 +1,4 @@
( function ( mw, $ ) {
- /* global wikEd */
-
/**
* Module handling diff page reloading and the RevisionSlider browser
history
*
@@ -77,16 +75,6 @@
mw.hook( 'wikipage.content' ).fire(
$contentText );
mw.hook( 'wikipage.diff' ).fire(
$contentText.find( 'table.diff' ) );
- // In order to correctly interact with
third-party code (extensions and gadgets)
- // Revision slider should trigger some general
(core) hook that other parties listen too
- // Following wikEdDiff.js-specific code is
deprecated and will be removed in the future.
- // WikEdDiff should be updated to use a hook.
- if ( self.wikEdDiffDetected() ) {
- mw.log( 'You are running WikEdDiff &
your copy of the code may need to be updated to work with the RevisionSlider.'
);
- mw.log( 'Please see:
https://phabricator.wikimedia.org/T143199#2631963' );
- mw.log( 'If WikEdDiff is still working
while using the RevisonSlider then the code change has already been done.' );
- }
-
}, function ( xhr ) {
$( 'table.diff[data-mw="interface"]'
).removeClass( 'mw-revslider-diff-loading' );
if ( xhr.statusText !== 'abort' ) {
@@ -99,10 +87,6 @@
// This could also attempt to reload
the page with the correct diff loaded without ajax?
}
} );
- },
-
- wikEdDiffDetected: function () {
- return typeof wikEd !== 'undefined' && $(
'meta[name=wikEdDiffSetupFlag]' ).length !== 0;
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/335248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I898234d72f496d0ce7299f18c121faf2fe174645
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
