Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/335699 )

Change subject: Hygiene: Merge footer v2 style module into default style module
......................................................................

Hygiene: Merge footer v2 style module into default style module

Note there are no caching issues with this change.
Although a cached HTML will request a url which refers to this module
this will print a problematic modules inline style at the top of the page
but still render the same.

Bug: T157075
Change-Id: I65de70de1f88d3746f835a2578423ab517264738
---
M extension.json
R resources/skins.minerva.base.styles/footer.less
2 files changed, 1 insertion(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/99/335699/1

diff --git a/extension.json b/extension.json
index 1376641..125e193 100644
--- a/extension.json
+++ b/extension.json
@@ -119,6 +119,7 @@
                                
"resources/skins.minerva.base.styles/common.less",
                                
"resources/skins.minerva.base.styles/icons.less",
                                
"resources/skins.minerva.base.styles/images.less",
+                               
"resources/skins.minerva.base.styles/footer.less",
                                "resources/skins.minerva.base.styles/print.less"
                        ]
                },
@@ -244,16 +245,6 @@
                                "user": 
"resources/skins.minerva.icons.images.scripts/userNormal.svg",
                                "anonymous": 
"resources/skins.minerva.icons.images.scripts/userAnonymous.svg"
                        }
-               },
-               "skins.minerva.footerV2.styles": {
-                       "targets": [
-                               "mobile",
-                               "desktop"
-                       ],
-                       "position": "top",
-                       "styles": [
-                               
"resources/skins.minerva.footerV2.styles/common.less"
-                       ]
                },
                "skins.minerva.mainPage.styles": {
                        "targets": [
diff --git a/resources/skins.minerva.footerV2.styles/common.less 
b/resources/skins.minerva.base.styles/footer.less
similarity index 100%
rename from resources/skins.minerva.footerV2.styles/common.less
rename to resources/skins.minerva.base.styles/footer.less

-- 
To view, visit https://gerrit.wikimedia.org/r/335699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65de70de1f88d3746f835a2578423ab517264738
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to