Ryan Lane has submitted this change and it was merged.
Change subject: gerrit: qa/* IRC notification to #wikimedia-dev
......................................................................
gerrit: qa/* IRC notification to #wikimedia-dev
The repositories such as qa/browsertests should not have notification
sent to #mediawiki. #wikimedia-dev seems to be a more appropriate place.
TEST PLAN:
$ python hookhelper_test.py
...............
----------------------------------------------------------------------
Ran 15 tests in 0.003s
OK
$
Change-Id: Id7f0084e961a400bb8c11e812ac6a17e54881d5f
---
M files/gerrit/hooks/hookhelper_test.py
M templates/gerrit/hookconfig.py.erb
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Ryan Lane: Looks good to me, approved
Cmcmahon: Looks good to me, but someone else must approve
Zfilipin: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/files/gerrit/hooks/hookhelper_test.py
b/files/gerrit/hooks/hookhelper_test.py
index 028fa35..ff25fc1 100644
--- a/files/gerrit/hooks/hookhelper_test.py
+++ b/files/gerrit/hooks/hookhelper_test.py
@@ -120,5 +120,9 @@
self.assertLogFile('mediawiki.log',
'department/project')
+ def test_qa_to_wikimediadev(self):
+ self.assertLogFile('wikimedia-dev.log',
+ 'qa/browsertests')
+
if __name__ == '__main__':
unittest.main()
diff --git a/templates/gerrit/hookconfig.py.erb
b/templates/gerrit/hookconfig.py.erb
index 87f6a4a..1eb5156 100644
--- a/templates/gerrit/hookconfig.py.erb
+++ b/templates/gerrit/hookconfig.py.erb
@@ -35,6 +35,7 @@
"mediawiki/*" : "mediawiki.log",
"mediawiki/tools/*" : "wikimedia-dev.log",
"operations/*": "operations.log",
+ "qa/*": "wikimedia-dev.log",
# SMW
"mediawiki/extensions/Semantic*" : "semantic-mediawiki.log",
--
To view, visit https://gerrit.wikimedia.org/r/50268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f0084e961a400bb8c11e812ac6a17e54881d5f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Ryan Lane <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: ใในใ <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
