Tim Landscheidt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/336367 )

Change subject: Do not manage service with package scripts
......................................................................

Do not manage service with package scripts

dh_installinit does not seem to generate a postrm script for
upstart-only services.  However as the service is explicitly managed
by Puppet, there is no need for starting or stopping the service on
package installation or removal anyway, so this change disables
dh_installinit amending the package scripts.

Bug: T156651
Change-Id: I22370a5d6c8e89ab7aa99d6a0e667a7e4ae5dc43
---
M debian/changelog
M debian/rules
2 files changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/software/tools-manifest 
refs/changes/67/336367/1

diff --git a/debian/changelog b/debian/changelog
index 4b2122f..f21fc13 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,8 +3,9 @@
   * Correct weekday in changelog entry
   * Add extended description to control
   * Generate man page for collector-runner
+  * Do not manage service with package scripts
 
- -- Tim Landscheidt <t...@tim-landscheidt.de>  Sun, 05 Feb 2017 06:33:23 +0000
+ -- Tim Landscheidt <t...@tim-landscheidt.de>  Tue, 07 Feb 2017 03:41:10 +0000
 
 tools-manifest (0.10) trusty; urgency=low
 
diff --git a/debian/rules b/debian/rules
index 05287db..80bfd91 100755
--- a/debian/rules
+++ b/debian/rules
@@ -18,5 +18,9 @@
        rm -f collector-runner.1
        dh_clean
 
+# The service is explicitly managed by Puppet, so there is no need to
+# start or stop it on package installation or removal.  In addition,
+# dh_installinit does not seem to generate a postrm script for
+# upstart-only services.
 override_dh_installinit:
-       dh_installinit --name=webservicemonitor
+       dh_installinit --noscripts --name=webservicemonitor

-- 
To view, visit https://gerrit.wikimedia.org/r/336367
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22370a5d6c8e89ab7aa99d6a0e667a7e4ae5dc43
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/tools-manifest
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to