Santhosh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336577 )
Change subject: Make sure the click event is always emitted to all translation
units
......................................................................
Make sure the click event is always emitted to all translation units
Section and Template translation units were not getting it since
SectionTranslationUnit override the onClick method.
Now that Section get the event, we don't need to register tools for
SentenceTranslationUnit.
All these event emitting pattern need to be better written with
documentation and assert that they dont get lost to consumers
Change-Id: I12b88ee564276e54f7d481c86b44d051f0ddf546
---
M modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
M modules/ui/translationunits/mw.cx.ui.SentenceTranslationUnit.js
2 files changed, 7 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/77/336577/1
diff --git a/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
b/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
index 33eb070..8d00db9 100644
--- a/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
+++ b/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
@@ -13,6 +13,9 @@
mw.cx.ui.SectionTranslationUnit.parent.call( this, model, view, config
);
// Mixin constructor
mw.cx.ui.mixin.AlignableTranslationUnit.call( this );
+ this.connect( this, {
+ click: 'translate'
+ } );
};
/* Setup */
@@ -23,7 +26,7 @@
mw.cx.ui.SectionTranslationUnit.static.matchTagNames = [ 'section' ];
mw.cx.ui.SectionTranslationUnit.static.highlightClass = 'cx-highlight';
-mw.cx.ui.SectionTranslationUnit.static.tools = [ 'search', 'formatter',
'machinetranslation', 'linker' ];
+mw.cx.ui.SectionTranslationUnit.static.tools = [ 'search', 'formatter',
'machinetranslation', 'dictionary' ];
mw.cx.ui.SectionTranslationUnit.prototype.render = function ( position ) {
this.addSourceSection( position );
@@ -76,9 +79,9 @@
};
/**
- * @inheritDoc
+ * Translate the section.
*/
-mw.cx.ui.SectionTranslationUnit.prototype.onClick = function () {
+mw.cx.ui.SectionTranslationUnit.prototype.translate = function () {
this.removeHighlight();
if ( this.translated ) {
diff --git a/modules/ui/translationunits/mw.cx.ui.SentenceTranslationUnit.js
b/modules/ui/translationunits/mw.cx.ui.SentenceTranslationUnit.js
index 92c025c..6b4afca 100644
--- a/modules/ui/translationunits/mw.cx.ui.SentenceTranslationUnit.js
+++ b/modules/ui/translationunits/mw.cx.ui.SentenceTranslationUnit.js
@@ -20,7 +20,7 @@
mw.cx.ui.SentenceTranslationUnit.static.matchTagNames = [ 'span' ];
mw.cx.ui.SentenceTranslationUnit.static.highlightClass = 'cx-highlight';
-mw.cx.ui.SentenceTranslationUnit.static.tools = [ 'search', 'formatter',
'machinetranslation', 'dictionary' ];
+mw.cx.ui.SentenceTranslationUnit.static.tools = [];
/**
* @inheritDoc
--
To view, visit https://gerrit.wikimedia.org/r/336577
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12b88ee564276e54f7d481c86b44d051f0ddf546
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
